fix: distinguish enum from spatial column

If an enum name contained a spatial type
name (e.g. "point"). It would be matched
by a regex as a sql type. This commit is
handling that by checking type metadata.

See rgeo/activerecord-postgis-adapter#432

Author: BuonOmo

lib/active_record/connection_adapters/cockroachdb/column.rb

@@ -27,9 +27,12 @@ def initialize(name, cast_type, default, sql_type_metadata = nil, null = true,
           super(name, cast_type, default, sql_type_metadata, null, default_function,
             collation: collation, comment: comment, serial: serial, generated: generated, identity: identity)
 
-          @geographic = sql_type_metadata.sql_type.match?(/geography\(/i)
           @hidden = hidden
 
+          return unless spatial?
+
+          @geographic = sql_type_metadata.sql_type.match?(/geography\(/i)
+
           if @geographic
             # Geographic type information is embedded in the SQL type
             @srid = 4326

test/cases/adapters/postgresql/postgis_test.rb

@@ -169,6 +169,20 @@ def test_multi_polygon_column
     assert_equal wkt, rec.m_poly.to_s
   end
 
+  def test_spatial_column_matching_enum
+    SpatialModel.lease_connection.create_enum(:point_type, ["point", "line_string", "polygon"])
+    SpatialModel.lease_connection.create_table(:spatial_models, force: true) do |t|
+      t.enum "point_type", enum_type: :point_type
+      t.column "latlon", :st_point, srid: 3785, geographic: true
+    end
+    SpatialModel.reset_column_information
+    _id, enum, geo = SpatialModel.columns
+    refute_predicate enum, :geographic?
+    refute_predicate enum, :spatial?
+    assert_predicate geo, :geographic?
+    assert_predicate geo, :spatial?
+  end
+
   private
 
   def klass