Skip to content

optimize: disassociate the gRPC server-side Stream Context lifecycle from server-side Transport#1914

Closed
DMwangnima wants to merge 1 commit intocloudwego:mainfrom
DMwangnima:optimize/grpc_ctx
Closed

optimize: disassociate the gRPC server-side Stream Context lifecycle from server-side Transport#1914
DMwangnima wants to merge 1 commit intocloudwego:mainfrom
DMwangnima:optimize/grpc_ctx

Conversation

@DMwangnima
Copy link
Contributor

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

optimize: 解除 gRPC Server 侧 Stream Context 和 Transport 的绑定

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@DMwangnima DMwangnima requested review from a team as code owners January 28, 2026 13:35
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.76%. Comparing base (bfa27f3) to head (4714df1).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1914      +/-   ##
==========================================
+ Coverage   61.37%   61.76%   +0.38%     
==========================================
  Files         388      390       +2     
  Lines       35063    30118    -4945     
==========================================
- Hits        21521    18601    -2920     
+ Misses      12247    10223    -2024     
+ Partials     1295     1294       -1     
Flag Coverage Δ
integration 51.97% <100.00%> (+1.46%) ⬆️
unit 51.99% <100.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DMwangnima
Copy link
Contributor Author

This change cannot completely isolate the memory reference relationship between the Client and Server Streams; it also requires converging the Server Transport injected into the Server Stream's context.

@DMwangnima DMwangnima closed this Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant