optimize: disassociate the gRPC server-side Stream Context lifecycle from server-side Transport#1914
Closed
DMwangnima wants to merge 1 commit intocloudwego:mainfrom
Closed
optimize: disassociate the gRPC server-side Stream Context lifecycle from server-side Transport#1914DMwangnima wants to merge 1 commit intocloudwego:mainfrom
DMwangnima wants to merge 1 commit intocloudwego:mainfrom
Conversation
…ver-side Transport
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1914 +/- ##
==========================================
+ Coverage 61.37% 61.76% +0.38%
==========================================
Files 388 390 +2
Lines 35063 30118 -4945
==========================================
- Hits 21521 18601 -2920
+ Misses 12247 10223 -2024
+ Partials 1295 1294 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
This change cannot completely isolate the memory reference relationship between the Client and Server Streams; it also requires converging the Server Transport injected into the Server Stream's context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
optimize
Check the PR title.
(Optional) Translate the PR title into Chinese.
optimize: 解除 gRPC Server 侧 Stream Context 和 Transport 的绑定
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: