feat: new extension scaffolding#79
Conversation
48283c4 to
3349043
Compare
mbiagetti
left a comment
There was a problem hiding this comment.
I've tested the command and do the job.
Don't know if we should also patch some wf like:
-
add the name
postgres-extensions-containers/.github/workflows/bake.yml
Lines 10 to 13 in 9d8ef22
-
add a new section
postgres-extensions-containers/.github/workflows/bake.yml
Lines 52 to 54 in 9d8ef22
That's a good point, but I'd keep it out of this PR. We can also think about some sort of required check to ensure tests have run on every modified target/extension |
@GabriFedi97 Agree, is a bit out-of-scope for the scaffolding task 👍 |
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Added copyright info Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Add validation for name, versions, distros parameters and template file existence. Extension names must contain only lowercase alphanumeric characters, hyphens, and underscores. Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Enhance error messages to include template file name and context, making it easier to debug template-related failures. Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Replace vector-specific example text with generic placeholders that developers should customize for their extensions. Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Replace unconventional <REMOVE> blocks with standard TODO comments for better readability and consistency with common practices. Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Add precondition to check NAME is not empty and improve error messages with usage examples. Add description to NAME variable requirement. Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
| # Include the extension's shared objects and related dependencies under the /lib directory. | ||
| # CNPG will load these libraries at runtime by configuring the dynamic linker path (LD_LIBRARY_PATH) and | ||
| # the PostgreSQL GUC "dynamic_library_path" based on defaults and Cluster configuration. | ||
| # CNPG will configure PostgreSQL to locate these libraries at runtime by configuring |
Add Dagger function and Taskfile entry to scaffold a new extension directory from scratch.
Documentation has been temporarily added to the
BUILD.mdfile but will probably be moved in a more appropriate section.Closes #17