chore: simplify maintenance skip condition

mnencia · mnencia · commit d8b12a23e7ce · 2026-04-09T14:28:10.000+02:00
Signed-off-by: Marco Nenciarini &lt;marco.nenciarini@enterprisedb.com&gt;
diff --git a/internal/cnpgi/instance/retention.go b/internal/cnpgi/instance/retention.go
@@ -91,8 +91,8 @@ func (c *CatalogMaintenanceRunnable) cycle(ctx context.Context) (time.Duration,
 	}
 
 	enabledPlugins := cnpgv1.GetPluginConfigurationEnabledPluginNames(cluster.Spec.Plugins)
-	if enabledForBackups := slices.Contains(enabledPlugins, metadata.PluginName); !enabledForBackups {
-		contextLogger.Debug("Skipping maintenance cycle: plugin is configured for restore only")
+	if !slices.Contains(enabledPlugins, metadata.PluginName) {
+		contextLogger.Debug("Skipping maintenance cycle: plugin is not enabled for backups")
 		return 0, nil
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -91,8 +91,8 @@ func (c *CatalogMaintenanceRunnable) cycle(ctx context.Context) (time.Duration,`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`enabledPlugins := cnpgv1.GetPluginConfigurationEnabledPluginNames(cluster.Spec.Plugins)`
`94`		`- if enabledForBackups := slices.Contains(enabledPlugins, metadata.PluginName); !enabledForBackups {`
`95`		`- contextLogger.Debug("Skipping maintenance cycle: plugin is configured for restore only")`
	`94`	`+ if !slices.Contains(enabledPlugins, metadata.PluginName) {`
	`95`	`+ contextLogger.Debug("Skipping maintenance cycle: plugin is not enabled for backups")`
`96`	`96`	`return 0, nil`
`97`	`97`	`}`
`98`	`98`