Changes from latest comments

Author: vkalapov

multiapps-mta/src/main/java/org/cloudfoundry/multiapps/mta/resolvers/ParameterChecker.java

@@ -21,7 +21,7 @@
 public abstract class ParameterChecker extends Visitor implements SimplePropertyVisitor {
     private List<CustomParameterContainer> unsupportedParameters;
 
-    private Set<String> currentParameters;
+    private Set<String> predefinedParametersForContainer;
 
     protected abstract Set<String> getModuleParametersToMatch();
 
@@ -70,7 +70,7 @@ public void visit(ElementContext context, Hook hook) {
     }
 
     private void matchAndStore(String name, Set<String> parametersToMatch, ParametersContainer parametersContainer, String prefixedName) {
-        this.currentParameters = parametersToMatch;
+        this.predefinedParametersForContainer = parametersToMatch;
         List<String> unmatched = findMatchesInParameters(parametersContainer);
         if (!unmatched.isEmpty()) {
             unsupportedParameters.add(new CustomParameterContainer(name, unmatched, prefixedName));
@@ -95,7 +95,7 @@ public Object visit(String key, String value) {
     }
 
     private String parameterKeyMatches(String valueToMatch) {
-        if (currentParameters != null && !currentParameters.contains(valueToMatch)) {
+        if (predefinedParametersForContainer != null && !predefinedParametersForContainer.contains(valueToMatch)) {
             return valueToMatch;
         }
         return null;

multiapps-mta/src/main/java/org/cloudfoundry/multiapps/mta/resolvers/ReferencePattern.java

@@ -1,11 +1,9 @@
 package org.cloudfoundry.multiapps.mta.resolvers;
 
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.List;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
-import java.util.stream.Collectors;
 
 public enum ReferencePattern implements ValueMatcher {
 
@@ -16,11 +14,7 @@ public enum ReferencePattern implements ValueMatcher {
     private String patternFormat;
 
     private final Pattern compiledPattern;
-
-    public static final List<Pattern> COMPILED_PATTERNS = Arrays.stream(values())
-                                                                .map(referencePattern -> referencePattern.compiledPattern)
-                                                                .collect(Collectors.toList());
-
+    
     ReferencePattern(String pattern, String patternFormat) {
         this.pattern = pattern;
         this.patternFormat = patternFormat;