Skip to content

Commit 2fcb4a9

Browse files
authored
Remove WG leads from *-bots teams (#1417)
- WG leads are (currently) humans - Humans are (currently) not bots - Automation currently configures branch protection to let the *-bots teams bypass PR requirements, which is not a desired default - If WG leads want to bypass PRs, they can still temporarily add themselves to the branch protection bypass list
1 parent 02ae694 commit 2fcb4a9

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

orgs/org_management/org_management.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ def _generate_wg_teams(wg: dict[str, Any]) -> tuple[str, dict[str, Any]]:
464464
f"{name}-bots": {
465465
"description": f"Bot accounts for {wg['name']} WG",
466466
"privacy": "closed",
467-
"maintainers": sorted(maintainers),
467+
"maintainers": [],
468468
"members": sorted({u["github"] for u in wg["bots"]} - maintainers),
469469
"repos": {r: "write" for r in repositories},
470470
},

orgs/org_management/test_org_management.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,7 @@ def test_generate_wg_teams(self):
500500
self.assertDictEqual({f"repo{i}": "admin" for i in range(1, 5)}, team["repos"])
501501

502502
team = wg_team["teams"]["wg-wg1-name-bots"]
503-
self.assertListEqual(["execution-lead-wg1", "technical-lead-wg1"], team["maintainers"])
503+
self.assertListEqual([], team["maintainers"])
504504
self.assertListEqual(["bot1-wg1"], team["members"])
505505
self.assertDictEqual({f"repo{i}": "write" for i in range(1, 5)}, team["repos"])
506506

@@ -542,7 +542,7 @@ def test_generate_wg_teams_exclude_non_org_repos(self):
542542
self.assertDictEqual({"repo10": "admin", "repo11": "admin"}, team["repos"])
543543

544544
team = wg_team["teams"]["wg-wg2-name-bots"]
545-
self.assertListEqual(["execution-lead-wg2", "technical-lead-wg2"], team["maintainers"])
545+
self.assertListEqual([], team["maintainers"])
546546
self.assertListEqual([], team["members"])
547547
self.assertDictEqual({"repo10": "write", "repo11": "write"}, team["repos"])
548548

0 commit comments

Comments
 (0)