nocloud: handle dict-of-strings public-keys format

The third branch of NoCloudConfigDriveService.get_public_keys() assumed
public-keys was a dict of {<name>: {'openssh-key': <key>}} (OpenStack
config drive shape) and called .get('openssh-key') on each value.

KubeVirt's accessCredentials sshPublicKey noCloud propagation method
serialises the keys as map[string]string, producing
{'key0': '<ssh-rsa ...>', 'key1': '<ssh-rsa ...>'} - dict whose values
are plain strings. With that input the plugin crashed with:

  ERROR cloudbaseinit.init [-] plugin 'SetUserSSHPublicKeysPlugin'
      failed with error "'str' object has no attribute 'get'"
    File "...nocloudservice.py", line 698, in get_public_keys
      public_keys = service.get_public_keys()

Accept both shapes: if the dict value is a string treat it as the SSH
key directly, otherwise keep the previous OpenStack-style extraction.

Reproduced on Windows Server 2022/2025 deployed on KubeVirt 1.8.x +
cloudbase-init 1.1.8 with the Cozystack vm-instance chart that wires
.Values.sshKeys into accessCredentials sshPublicKey + noCloud
propagation. KubeVirt source for the format: pkg/cloud-init/cloud-init.go,
type NoCloudMetadata PublicSSHKeys map[string]string.

Adds a regression unit test test_get_public_keys_dict_of_strings
mirroring the existing test_get_public_keys / test_get_public_keys_alt_fmt
pattern.

Signed-off-by: mattia-eleuteri <mattia@hidora.io>

Author: mattia-eleuteri

cloudbaseinit/metadata/services/nocloudservice.py

@@ -695,7 +695,14 @@ def get_public_keys(self):
         if isinstance(raw_ssh_keys, list):
             return raw_ssh_keys
 
-        return [raw_ssh_keys[key].get('openssh-key') for key in raw_ssh_keys]
+        # raw_ssh_keys may be a dict in two shapes:
+        #   1) {<key-name>: {'openssh-key': <key>}}     (OpenStack-style)
+        #   2) {<key-name>: <key>}                      (KubeVirt-style)
+        # KubeVirt serialises NoCloudMetadata.PublicSSHKeys as
+        # map[string]string, hitting case 2; treat string values directly so
+        # we don't crash with "'str' object has no attribute 'get'".
+        return [v if isinstance(v, str) else v.get('openssh-key')
+                for v in raw_ssh_keys.values()]
 
     def get_network_details(self):
         debian_net_config = self._get_meta_data().get('network-interfaces')

cloudbaseinit/tests/metadata/services/test_nocloudservice.py

@@ -516,6 +516,23 @@ def test_get_public_keys_alt_fmt(self, mock_get_metadata):
         result = self._config_drive.get_public_keys()
         self.assertEqual(result, expected_result)
 
+    @mock.patch(MODULE_PATH + '.NoCloudConfigDriveService._get_meta_data')
+    def test_get_public_keys_dict_of_strings(self, mock_get_metadata):
+        # KubeVirt serialises accessCredentials sshPublicKey noCloud as
+        # map[string]string, which deserialises to a dict whose values are
+        # plain SSH key strings (not the OpenStack {'openssh-key': ...}
+        # shape). The plugin must accept both formats.
+        fake_key0 = 'ssh-rsa AAAA0 user0@host'
+        fake_key1 = 'ssh-rsa AAAA1 user1@host'
+        mock_get_metadata.return_value = {
+            'public-keys': {
+                'key0': fake_key0,
+                'key1': fake_key1,
+            }
+        }
+        result = sorted(self._config_drive.get_public_keys())
+        self.assertEqual(result, sorted([fake_key0, fake_key1]))
+
     @ddt.data(('', ('V2 network metadata is empty', None)),
               ('1', ('V2 network metadata is not a dictionary', None)),
               ('{}', ('V2 network metadata is empty', None)),