Use super only for before ActiveRecord major version 5

Otherwise, use a hard-coded legacy version of ActiveRecord::Inheritance::ClassMethods#find_sti_class

Author: tylersuzukinelson

lib/inheritance_integer_type/extensions.rb

@@ -9,7 +9,27 @@ def integer_inheritance=(val)
 
       def find_sti_class(type_name)
         lookup = self._inheritance_mapping[type_name.to_i]
-        lookup ? super(lookup) : super
+        if lookup
+          if ActiveRecord::VERSION::MAJOR < 5
+            super(lookup)
+          else
+            begin
+              if store_full_sti_class
+                ActiveSupport::Dependencies.constantize(lookup)
+              else
+                compute_type(lookup)
+              end
+            rescue NameError
+              raise SubclassNotFound,
+                "The single-table inheritance mechanism failed to locate the subclass: '#{type_name}'. " +
+                "This error is raised because the column '#{inheritance_column}' is reserved for storing the class in case of inheritance. " +
+                "Please rename this column if you didn't intend it to be used for storing the inheritance class " +
+                "or overwrite #{name}.inheritance_column to use another column for that information."
+            end
+          end
+        else
+          super
+        end
       end
 
       def sti_name_with_integer_types

lib/inheritance_integer_type/version.rb

@@ -1,3 +1,3 @@
 module InheritanceIntegerType
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

spec/inheritance_integer_type_spec.rb

@@ -1,58 +1,59 @@
 require 'spec_helper'
 require 'pry'
 describe InheritanceIntegerType do
+  [3,5].each do |major_version|
+    let(:base) { Base.create(name: "Hello") }
+    let(:left) { LeftChild.create(name: "Hello") }
+    let(:deep) { DeepChild.create(name: "Hello") }
+
+    before { allow(ActiveRecord::VERSION).to receive(:MAJOR).and_return(major_version) }
+
+    describe "The parent" do
+      subject { base }
+      it { is_expected.to be_persisted }
+      it "has no type" do
+        expect(subject.type).to be_nil
+      end
+      it { is_expected.to eql Base.first }
+    end
 
-  let(:base) { Base.create(name: "Hello") }
-  let(:left) { LeftChild.create(name: "Hello") }
-  let(:deep) { DeepChild.create(name: "Hello") }
+    describe "The inherited classes" do
+      subject { left }
+      it { is_expected.to be_persisted }
+      it { is_expected.to eql LeftChild.first }
+    end
 
-  describe "The parent" do
-    subject { base }
-    it { is_expected.to be_persisted }
-    it "has no type" do
-      expect(subject.type).to be_nil
+    describe "The deep inherited classes" do
+      subject { deep }
+      it { is_expected.to be_persisted }
+      it { is_expected.to eql DeepChild.first }
     end
-    it { is_expected.to eql Base.first }
-  end
 
-  describe "The inherited classes" do
-    subject { left }
-    it { is_expected.to be_persisted }
-    it { is_expected.to eql LeftChild.first }
-  end
+    describe "Belongs to associations" do
 
-  describe "The deep inherited classes" do
-    subject { deep }
-    it { is_expected.to be_persisted }
-    it { is_expected.to eql DeepChild.first }
-  end
+      let(:belong) { BelongsTo.create(base: base, left_child: left) }
+      subject { belong }
 
-  describe "Belongs to associations" do
+      it "properly assocaites the base class" do
+        expect(subject.base).to eql base
+      end
 
-    let(:belong) { BelongsTo.create(base: base, left_child: left) }
-    subject { belong }
+      it "properly assocaites the children class" do
+        expect(subject.left_child).to eql left
+      end
 
-    it "properly assocaites the base class" do
-      expect(subject.base).to eql base
-    end
 
-    it "properly assocaites the children class" do
-      expect(subject.left_child).to eql left
     end
 
-
-  end
-
-  describe "Has many associations" do
-    let(:other) { Other.create }
-    before do
-      [base, left, deep].each{|a| a.update_attributes(other: other) }
+    describe "Has many associations" do
+      let(:other) { Other.create }
+      before do
+        [base, left, deep].each{|a| a.update_attributes(other: other) }
+      end
+      subject { other }
+      it "properly finds the classes through the association" do
+        expect(other.bases).to match_array [base, left, deep]
+      end
     end
-    subject { other }
-    it "properly finds the classes through the association" do
-      expect(other.bases).to match_array [base, left, deep]
-    end
-
   end
-
 end

spec/spec_helper.rb

@@ -6,8 +6,6 @@
 require 'support/deep_child'
 require 'support/other'
 require 'support/belongs_to'
-# require 'support/old_style'
-# require 'support/inherit_old_style'
 
 RSpec.configure do |config|
 

spec/support/active_record.rb

@@ -5,7 +5,7 @@
   :adapter => "mysql2",
   :host => "localhost",
   :database => "inheritance_integer_type_test",
-  :username => "root",
-  :password => "iasEcerdyetvanyet"
+  :username => "iit",
+  :password => ""
 }
 ActiveRecord::Base.establish_connection(config)