Merge pull request #76 from clawfleet/fix/auto-pull-on-create

fix: auto-pull image on create if not found locally

Author: weiyong1024

internal/cli/create.go

@@ -28,7 +28,7 @@ var createCmd = &cobra.Command{
 }
 
 func init() {
-	createCmd.Flags().BoolVar(&pullFlag, "pull", false, "Force re-pull image even if found locally")
+	createCmd.Flags().BoolVar(&pullFlag, "pull", false, "Force re-pull image from registry (even if already present locally)")
 	createCmd.Flags().StringVar(&fromSnapshotFlag, "from-snapshot", "", "Create instance from a saved snapshot")
 }
 
@@ -48,21 +48,21 @@ func runCreate(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
-	// Check image exists
+	// Check image exists; auto-pull if missing, force-pull if --pull flag set.
 	exists, err := container.ImageExists(cli, cfg.ImageRef())
 	if err != nil {
 		return err
 	}
-	if !exists {
-		if pullFlag {
+	if !exists || pullFlag {
+		if !exists {
 			fmt.Printf("Image %s not found locally, pulling from registry...\n", cfg.ImageRef())
-			if pullErr := container.PullImage(cli, cfg.Image.Name, cfg.Image.Tag, os.Stdout); pullErr != nil {
-				return fmt.Errorf("pull failed: %v\nRun 'clawfleet build' to build it manually", pullErr)
-			}
-			fmt.Println("Image pulled successfully.")
 		} else {
-			return fmt.Errorf("Image %s not found. Run 'clawfleet build' or build via Dashboard.\nUse --pull to pull from the registry instead.", cfg.ImageRef())
+			fmt.Printf("Pulling latest %s from registry...\n", cfg.ImageRef())
+		}
+		if pullErr := container.PullImage(cli, cfg.Image.Name, cfg.Image.Tag, os.Stdout); pullErr != nil {
+			return fmt.Errorf("pull failed: %v\nRun 'clawfleet build' to build it manually", pullErr)
 		}
+		fmt.Println("Image pulled successfully.")
 	}
 
 	// Ensure network

internal/web/handlers.go

@@ -3,6 +3,7 @@ package web
 import (
 	"encoding/json"
 	"fmt"
+	"io"
 	"log"
 	"net/http"
 	"os"
@@ -105,9 +106,13 @@ func (s *Server) handleCreateInstances(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 	if !exists {
-		writeError(w, http.StatusPreconditionFailed, fmt.Sprintf(
-			"Image %s not found. Build the image via System → Image in the Dashboard, or run 'clawfleet build'.", cfg.ImageRef()))
-		return
+		log.Printf("Image %s not found locally, pulling from registry...", cfg.ImageRef())
+		if err := container.PullImage(s.docker, cfg.Image.Name, cfg.Image.Tag, io.Discard); err != nil {
+			writeError(w, http.StatusPreconditionFailed, fmt.Sprintf(
+				"Image %s not found locally and pull failed: %v", cfg.ImageRef(), err))
+			return
+		}
+		log.Printf("Image %s pulled successfully", cfg.ImageRef())
 	}
 
 	if err := container.EnsureNetwork(s.docker); err != nil {