nvmeof: enable rbd crc option by default

Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>

Author: Alexander Indenbaum

.github/workflows/build-container.yml

@@ -507,7 +507,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        test: ["sanity", "no_huge", "ns_lb_change", "no_subsystems", "auto_load_balance", "state_transitions", "state_transitions_both_gws", "state_transitions_loop", "state_transitions_rand_loop", "late_registration", "late_registration_loop", "connect_panic", "4gws", "4gws_loop", "4gws_create_delete", "4gws_create_delete_loop", "namespaces", "namespaces_loop", "mtls", "notify", "ceph_status", "blocklist", "main_exit", "listener_hostname", "cluster_pool", "flat_bdev_per_cluster", "set_qos", "set_qos_2ms", "rbd_qos", "auto_resize", "ns_read_only", "reuse_image", "reuse_image2", "image_shrink", "gateway_removal", "rados_namespace", "crc32c"]
+        test: ["sanity", "no_huge", "ns_lb_change", "no_subsystems", "auto_load_balance", "state_transitions", "state_transitions_both_gws", "state_transitions_loop", "state_transitions_rand_loop", "late_registration", "late_registration_loop", "connect_panic", "4gws", "4gws_loop", "4gws_create_delete", "4gws_create_delete_loop", "namespaces", "namespaces_loop", "mtls", "notify", "ceph_status", "blocklist", "main_exit", "listener_hostname", "cluster_pool", "flat_bdev_per_cluster", "set_qos", "set_qos_2ms", "rbd_qos", "auto_resize", "ns_read_only", "reuse_image", "reuse_image2", "image_shrink", "gateway_removal", "rados_namespace", "nocrc"]
     runs-on: ubuntu-latest
     env:
       HUGEPAGES: 1024  # 4 spdk instances

ceph-nvmeof.conf

@@ -100,8 +100,8 @@ timeout = 60.0
 # DSA CRC32 acceleration, enabled by default
 #enable_dsa_acceleration = False
 
-# RBD CRC32C usage, disabled by default
-#rbd_with_crc32c = False
+# RBD CRC32C usage, enabled by default
+#rbd_with_crc32c = True
 
 # Example value: -m 0x3 -L all
 # tgt_cmd_extra_args =

control/server.py

@@ -865,7 +865,7 @@ def _set_num_ssl_tickets(self, tickets_number=0):
     def _initialize_rbd_crc32c(self):
         """Initialize RBD CRC32C configuration."""
 
-        rbd_with_crc32c = self.config.getboolean_with_default("spdk", "rbd_with_crc32c", False)
+        rbd_with_crc32c = self.config.getboolean_with_default("spdk", "rbd_with_crc32c", True)
         self.logger.debug(f"initialize_rbd_crc32c: rbd_with_crc32c: {rbd_with_crc32c}")
 
         try:

tests/ceph-nvmeof.crc32c.conf tests/ceph-nvmeof.nocrc.conftests/ceph-nvmeof.crc32c.conf renamed to tests/ceph-nvmeof.nocrc.conf

@@ -97,8 +97,8 @@ timeout = 60.0
 # DSA CRC32 acceleration, enabled by default
 #enable_dsa_acceleration = False
 
-# RBD CRC32C usage, enabled for testing
-rbd_with_crc32c = True
+# RBD CRC32C usage, disabled for testing
+rbd_with_crc32c = False
 
 # Example value: -m 0x3 -L all
 # tgt_cmd_extra_args =
@@ -117,3 +117,4 @@ qos_timeslice_in_usecs = 0
 [monitor]
 #timeout = 1.0
 #log_file_dir =
+

tests/ha/crc32c.sh tests/ha/nocrc.shtests/ha/crc32c.sh renamed to tests/ha/nocrc.sh

@@ -9,5 +9,6 @@ else
     test_dir=$(dirname $0)
 fi
 
-export NVMEOF_CONFIG=./tests/ceph-nvmeof.crc32c.conf
-$test_dir/start_up.sh
+export NVMEOF_CONFIG=./tests/ceph-nvmeof.nocrc.conf
+$test_dir/start_up.sh
+