nvmeof: validate unknown parameters in ControllerModifyVolume

Add validation to reject unknown mutable parameters in the NVMe-oF
ControllerModifyVolume implementation. Previously, unknown parameters
were silently ignored, which could lead to confusion when users
specify incorrect parameter names.

The validation now checks that only known parameters (QoS parameters:
rwIosPerSecond, rwMbytesPerSecond, rMbytesPerSecond, wMbytesPerSecond,
and host parameter: allowHostNQNs) are provided, returning an
InvalidArgument error for any unknown parameters.

Assisted-by: AskBob <askbob@ibm.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>

Author: nixpanic

internal/nvmeof/controller/controllerserver.go

@@ -23,6 +23,7 @@ import (
 	"fmt"
 	"maps"
 	"net"
+	"slices"
 	"strconv"
 
 	"github.com/container-storage-interface/spec/lib/go/csi"
@@ -370,7 +371,23 @@ func (cs *Server) ControllerModifyVolume(
 	}
 	defer cs.volumeLocks.Release(volumeID)
 
-	// Step 2: Parse QoS parameters from mutable_parameters
+	// Step 2: Validate that only known parameters are provided
+	knownParams := []string{
+		nvmeof.RwIosPerSecond,
+		nvmeof.RwMbytesPerSecond,
+		nvmeof.RMbytesPerSecond,
+		nvmeof.WMbytesPerSecond,
+		nvmeof.AllowHostNQNs,
+	}
+
+	for param := range params {
+		if !slices.Contains(knownParams, param) {
+			return nil, status.Errorf(codes.InvalidArgument,
+				"unknown mutable parameter: %s", param)
+		}
+	}
+
+	// Step 3: Parse QoS parameters from mutable_parameters
 	hasRBDQoS := rbd.HasQoSParams(params)
 	if hasRBDQoS {
 		log.ErrorLog(ctx, "Cannot set RBD QoS parameters on NVMe-oF volumes")
@@ -491,6 +508,21 @@ func validateCreateVolumeRequest(req *csi.CreateVolumeRequest) error {
 	// Validate QoS parameters - cannot mix RBD and NVMe-oF QoS
 	mutableParams := req.GetMutableParameters()
 
+	// Validate that only known mutable parameters are provided
+	knownMutableParams := []string{
+		nvmeof.RwIosPerSecond,
+		nvmeof.RwMbytesPerSecond,
+		nvmeof.RMbytesPerSecond,
+		nvmeof.WMbytesPerSecond,
+		nvmeof.AllowHostNQNs,
+	}
+
+	for param := range mutableParams {
+		if !slices.Contains(knownMutableParams, param) {
+			return fmt.Errorf("unknown mutable parameter: %s", param)
+		}
+	}
+
 	// check for RBD QoS parameters in both params and mutableParams
 	if hasRBDQoS := rbd.HasQoSParams(params); hasRBDQoS {
 		return errors.New("setting RBD QoS parameters on NVMe-oF volumes is not supported")