optimizing internal call with version

Author: sahusanket

cdap-app-fabric/src/main/java/io/cdap/cdap/gateway/handlers/ProgramLifecycleHttpHandlerInternal.java

@@ -24,6 +24,8 @@
 import io.cdap.cdap.internal.app.services.ProgramLifecycleService;
 import io.cdap.cdap.internal.app.store.RunRecordDetail;
 import io.cdap.cdap.proto.ProgramType;
+import io.cdap.cdap.proto.id.ApplicationId;
+import io.cdap.cdap.proto.id.ProgramId;
 import io.cdap.cdap.proto.id.ProgramReference;
 import io.cdap.http.HttpHandler;
 import io.cdap.http.HttpResponder;
@@ -72,9 +74,10 @@ public void getProgramRunRecordMeta(HttpRequest request, HttpResponder responder
       @PathParam("program-name") String programName,
       @PathParam("run-id") String runid) throws Exception {
     ProgramType programType = ProgramType.valueOfCategoryName(type, BadRequestException::new);
-    ProgramReference programRef = new ProgramReference(namespaceId, appName, programType,
+
+    ProgramId progId = new ApplicationId(namespaceId, appName, appVersion).program(programType,
         programName);
-    RunRecordDetail runRecordMeta = programLifecycleService.getRunRecordMeta(programRef, runid);
+    RunRecordDetail runRecordMeta = programLifecycleService.getRunRecordMeta(progId.run(runid));
     responder.sendJson(HttpResponseStatus.OK, GSON.toJson(runRecordMeta));
   }
 }

cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/services/ProgramLifecycleService.java

@@ -333,6 +333,25 @@ public RunRecordDetail getRunRecordMeta(ProgramReference programRef, String runI
     return runRecord;
   }
 
+  public RunRecordDetail getRunRecordMeta(ProgramRunId id)
+      throws Exception {
+    accessEnforcer.enforce(new ProgramReference(id.getNamespace(), id.getApplication(),
+            id.getType(), id.getProgram()),
+        authenticationContext.getPrincipal(),
+        StandardPermission.GET);
+    RunRecordDetail runRecord = store.getRun(id);
+    if (runRecord == null) {
+      throw new NotFoundException(
+          String.format("No run record found for program %s and runID: %s", id.getProgram(), id.getRun()));
+    }
+    ApplicationId appId = runRecord.getProgramRunId().getParent().getParent();
+    ApplicationSpecification appSpec = store.getApplication(appId);
+    if (appSpec == null) {
+      throw new ApplicationNotFoundException(appId);
+    }
+    return runRecord;
+  }
+
   /**
    * Get the latest runs within the specified start and end times for the specified program.
    *