Skip to content

Commit 0111685

Browse files
Merge pull request #312 from cloudsufi/feat/window-size-workflow-dispatch
window size changes and workflow dispatch for release/6.11
2 parents 0c4148a + 3206392 commit 0111685

4 files changed

Lines changed: 7 additions & 5 deletions

File tree

.github/workflows/deploy.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
name: Maven Deploy
1313

1414
on:
15+
workflow_dispatch:
16+
push:
17+
branches: [ release/6.11 ]
1518
workflow_call:
1619
inputs:
1720
ref:
@@ -27,7 +30,7 @@ jobs:
2730

2831
- name: Get Secrets from GCP Secret Manager
2932
id: 'secrets'
30-
uses: 'google-github-actions/get-secretmanager-secrets@v0'
33+
uses: 'google-github-actions/get-secretmanager-secrets@v2'
3134
with:
3235
secrets: |-
3336
CDAP_OSSRH_USERNAME:cdapio-github-builds/CDAP_OSSRH_USERNAME

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ the License.-->
1818
<modelVersion>4.0.0</modelVersion>
1919
<groupId>io.cdap.tests.e2e</groupId>
2020
<artifactId>cdap-e2e-framework</artifactId>
21-
<version>0.4.2-SNAPSHOT</version>
21+
<version>0.4.2</version>
2222

2323
<name>CDAP e2e Framework</name>
2424
<description>Framework for CDAP e2e Tests</description>

src/main/java/io/cdap/e2e/utils/SeleniumDriver.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public class SeleniumDriver {
4949
ChromeOptions chromeOptions = new ChromeOptions();
5050
chromeOptions.addArguments("--no-sandbox");
5151
chromeOptions.addArguments("--disable-setuid-sandbox");
52-
chromeOptions.addArguments("--headless");
52+
chromeOptions.addArguments("--headless=new");
5353
chromeOptions.addArguments("--window-size=" + SeleniumHelper.readParameters("windowSize"));
5454
chromeOptions.addArguments("--disable-gpu");
5555
chromeOptions.addArguments("--disable-dev-shm-usage");
@@ -62,7 +62,6 @@ public class SeleniumDriver {
6262
chromePrefs.put("download.default_directory", downloadDir);
6363
chromeOptions.setExperimentalOption("prefs", chromePrefs);
6464
chromeDriver = new ChromeDriver(service, chromeOptions);
65-
chromeDriver.manage().window().maximize();
6665
HttpCommandExecutor executor = (HttpCommandExecutor) chromeDriver.getCommandExecutor();
6766
url = executor.getAddressOfRemoteServer();
6867
waitDriver = new WebDriverWait(chromeDriver, ConstantsUtil.DEFAULT_TIMEOUT_SECONDS);

src/main/resources/connectionParameters.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Selenium browser window size
2-
windowSize=1920x1040
2+
windowSize=1920,1040
33
# CDAP application url
44
cdfurl=http://localhost:11011/pipelines/ns/default/studio
55
# CDAP Wrangler connections page url

0 commit comments

Comments
 (0)