Skip to content

Fix domain name in CONTRIBUTING.md helloworld setup #8331

Description

@Scanf-s

Description

The helloworld sample expects the domain cadence-samples but CONTRIBUTING.md instructs registering samples-domain so following the guide as-is fails.
It is just tiny document update, so I want to update a document of this problem by modifying domain registration line from ./cadence --do samples-domain domain register to ./cadence --do cadence-samples domain register (and if it's okay, update the execution logs too).

Steps to Reproduce / How to Trigger

  1. Follow the CONTRIBUTING.md guide to setup the dev environment
  2. Register domain like this
  3. Clone the sample repo, and follow the instructions.
  4. If you run ./bin/helloworld -m worker &, error message occurs like this. As you can see, hello world application requires cadence-samples domain.
jace@Jace:~/dev/cadence-samples$ 2026-07-21T00:22:32.564+0900   INFO    common/sample_helper.go:111     Logger created.
2026-07-21T00:22:32.564+0900    DEBUG   common/factory.go:162   Creating RPC dispatcher outbound        {"ServiceName": "cadence-frontend", "HostPort": "localhost:7833"}
2026-07-21T00:22:32.567+0900    FATAL   common/sample_helper.go:162     Domain doesn't exist    {"Domain": "cadence-samples", "error": "EntityNotExistsError{Message: Domain cadence-samples does not exist., CurrentCluster: , ActiveCluster: , ActiveClusters: []}"}
github.com/uber-common/cadence-samples/cmd/samples/common.(*SampleHelper).SetupServiceConfig
        /home/jace/dev/cadence-samples/cmd/samples/common/sample_helper.go:162
main.main
        /home/jace/dev/cadence-samples/cmd/samples/recipes/helloworld/main.go:67
runtime.main
        /home/linuxbrew/.linuxbrew/Cellar/go/1.26.5/libexec/src/runtime/proc.go:290
^C
[1]+  Exit 1                  ./bin/helloworld -m worker
jace@Jace:~/dev/cadence-samples$

Expected Behavior

Hello world sample should run by following instructions.

Actual Behavior

The sample application produces a Domain cadence-samples does not exist error.

Logs / Screenshots

Image

Environment

  • Cadence server version: Server version or build SHA
  • Cadence SDK language and version (if applicable): Language and SDK version
  • Cadence web version (if applicable): Web UI version
  • DB & version: Database type and version
  • Scale: Cluster size, workload volume, or other scale details

Metadata

Metadata

Labels

bugDEPRECATED -> use kind/bugkind/bugExisting behavior is broken or not working as documented/intended.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions