Zstd checksum should be configurable #7585
Description
Issue Details
In klauspost/compress, the encoder default is crc: true
In facebook/zstd, ZSTD_c_checksumFlag has default 0. (https://facebook.github.io/zstd/zstd_manual.html). This is the reference standard and used in other load balancers (e.g., the nginx-zstd extensions).
Brotli does not use a checksum.
It's a small speedup, 1-4% in my testing.
I would argue that the zstd checksum is providing little value on a high-throughput (normal) web server:
- TCP already detects random transmission errors.
- TLS already provides strong integrity protection against tampering.
- If the zstd compressed data is corrupted, what is the browser going to do? I assume the user is just going to retry the request!
Assistance Disclosure
AI not used
If AI was used, describe the extent to which it was used.
No AI used in my Github browsing.