wasm-wave: catch error in UntypedFuncCall::to_wasm_params

Author: pchickey

crates/wasm-wave/src/untyped.rs

@@ -2,7 +2,7 @@
 
 use alloc::{borrow::Cow, vec::Vec};
 
-use crate::{Parser, WasmValue, ast::Node, lex::Keyword, parser::ParserError};
+use crate::{Parser, WasmValue, ast::Node, lex::Keyword, parser::{ParserError, ParserErrorKind}};
 
 /// An UntypedValue is a parsed but not type-checked WAVE value.
 #[derive(Clone, Debug)]
@@ -121,11 +121,22 @@ impl<'source> UntypedFuncCall<'source> {
     /// be returned as `none` values.
     pub fn to_wasm_params<'types, V: WasmValue + 'static>(
         &self,
-        types: impl IntoIterator<Item = &'types V::Type>,
-    ) -> Result<Vec<V>, ParserError> {
+        types: impl IntoIterator<Item = &'types V::Type, IntoIter: ExactSizeIterator>,
+    ) -> Result<Vec<V>, ParserError>
+    {
         match &self.params {
             Some(params) => params.to_wasm_params(types, self.source()),
-            None => Ok(Vec::new()),
+            None => {
+                let num_params = types.into_iter().len();
+                if num_params > 0 {
+                    return Err(ParserError::with_detail(
+                        ParserErrorKind::InvalidParams,
+                        self.name.clone(),
+                        alloc::format!("no params provided, but {num_params} required")
+                    ));
+                }
+                Ok(Vec::new())
+            }
         }
     }
 }

crates/wasm-wave/tests/ui/reject-strings.out

@@ -30,3 +30,5 @@ unexpected token: LabelOrKeyword at 25..30
 // Multiline invalid escapes
 invalid character escape at 30..31
 invalid character escape at 27..28
+// Missing argument
+invalid params: no params provided, but 1 required at 0..6

crates/wasm-wave/tests/ui/reject-strings.waves

@@ -43,4 +43,6 @@ Invalid surrogate: \u{d800}
 """);
 string("""
 Invalid escape: \j
-""");
+""");
+// Missing argument
+string();