Conversation
lcreid
force-pushed
the
upgrade-selenium
branch
4 times, most recently
from
b27eff7 to
f2053ec
Compare
Merged
Had to up the screen size for the tests. I don't know why it worked until now. Although looking at the browser in non-headless, there was a new box at the top of the page saying the browser was being driven for tests. Maybe that changed the dimensions enough?
This soon won't be needed, as 6.1 is out of support and 7.0 is about to be.
lcreid
force-pushed
the
upgrade-selenium
branch
from
f2053ec to
b7526d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue with Selenium that I've forgotten already. But it needed to be updated to new webdrivers.
The issue seemed to be (after days of debugging) that some dimensions must have changed. When I was debugging and looking at the actual browser session, there was a banner across the top of the window to say that the browser was being controlled by test software. Perhaps that moved things enough that the code for cropping was broken. In the end, I just expanded the area to capture.
For some reason all the PNGs changed. I guess that's just going to happen to use, when the underlying containers change their behaviour about fonts or other rendering characteristics.