Add define BOOST_PARSER_DISABLE_TRACE to disable trace mode at compile time#267
Add define BOOST_PARSER_DISABLE_TRACE to disable trace mode at compile time#267andreasbuhr wants to merge 1 commit intoboostorg:developfrom
Conversation
andreasbuhr
force-pushed
the
introduce_define_disable_trace
branch
from
b131312 to
032c558
Compare
|
I'd be much happier merging this if it had a proper place in config.hpp, and had associated documentation. I think this is reasonable, so I'll do it eventually, but it's pretty low priority for me. |
|
Great. I'll improve this Pull Request over time and rebase it on develop from time to time. Expect it to be polished in mid of January. |
andreasbuhr
changed the title
andreasbuhr
force-pushed
the
introduce_define_disable_trace
branch
2 times, most recently
from
798e5dc to
15a5eab
Compare
andreasbuhr
force-pushed
the
introduce_define_disable_trace
branch
3 times, most recently
from
42624bc to
6848ed4
Compare
andreasbuhr
changed the title
…e time. The trace feature doubles the compile time, even if never used. This patch introduces the preprocessor define BOOST_PARSER_DISABLE_TRACE to deactivate this feature at compile time.
andreasbuhr
force-pushed
the
introduce_define_disable_trace
branch
from
6848ed4 to
399eb5b
Compare
|
Rebased on develop. |
|
I'm not going to commit this as-is, because of nits about the way you wrote the change; the semantics seem fine. It was quicker to just change it to my liking than to describe what I wanted changed. See your modified commit on the https://github.com/boostorg/parser/tree/introduce_define_disable_trace branch if you're curious. The tl;dr is I introduced a "private"/undocumented macro that I hang everything off of, and define it based on whether the user defines the user-facing one. This is the pattern for all macros in all my Boost libs. One advantage of doing this is that you can treat the macro as a constant, and don't need Superceded by PR #314 . |
2 participants
The trace feature doubles the compile time, even if never used. This patch introduces the preprocessor define BOOST_PARSER_DISABLE_TRACE to deactivate this feature at compile time.