Not working on GitHub enterprise

[lcmgh]

(Use node --trace-deprecation ... to show where the warning was created)
Warning: Failed to comment: HttpError: request to https://mycompany/api/v3/repos/myorg/myrepo/issues/9/comments failed, reason: tunneling socket could not be established, statusCode=503
Commenting is not possible from forks.
┌─────────┬────────────────────────────┬─

- uses: boa-dev/criterion-compare-action@6fdd4e866a4d4539e126afc158249a7631cc842e
  with:
    benchName: "my_benchmark"
    # Needed. The name of the branch to compare with. This default uses the branch which is being pulled against
    branchName: ${{ github.base_ref }}
    # Optional. Default is `${{ github.token }}`.
    token: ${{ secrets.GITHUB_TOKEN }}

[Razican]

Which version of GitHub Enterprise is this? We now use Node 16, which might not be available in all GitHub Enterprise versions.

[lcmgh]

The benchmark itself run through fine. What I am getting in the end is:

Warning: Failed to comment: HttpError: request to https://my-enterprise.com/api/v3/repos/myorg/my-service/issues//comments failed, reason: tunneling socket could not be established, statusCode=503
Commenting is not possible from forks.

GitHub Enterprise Server 3.4.3

[Razican]

The benchmark itself run through fine. What I am getting in the end is:

Warning: Failed to comment: HttpError: request to https://my-enterprise.com/api/v3/repos/myorg/my-service/issues//comments failed, reason: tunneling socket could not be established, statusCode=503

Commenting is not possible from forks.

GitHub Enterprise Server 3.4.3

Hmm is the PR coming from a fork, instead of a branch in the same repo?

[lcmgh]

The log from the previous comment came indeed from a branch triggered build and not from a PR, sorry for that.

I have now triggered the action from a pull request and it says

(node:745370) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
Warning: Failed to comment: HttpError: request to https://my-company.com/api/v3/repos/myorg/myproject/issues/15/comments failed, reason: tunneling socket could not be established, statusCode=503
Commenting is not possible from forks.
┌─────────┬────────────────────────────

The URL of my PR is https://my-company.com/myorg/myproject/pull/15

The runner has appropriate proxy settings (HTTP_PROXY, HTTPS_PROXY, NO_PROXY) in place to use a proxy for intranet-internet connections and none for internal connections (such as the GitHub enterprise it is connected to).

[Razican]

Note that GitHub doesn't allow writing comments from forks. This is a known limitation in GitHub, and there is nothing that can be done about it, unfortunately :(

[lcmgh]

Actually the PR comes from the same repository.

[Lurk]

To anyone who lands here and has PR without a fork - you lack permission.

on: [pull_request]
name: benchmark pull requests
jobs:
  runBenchmark:
    name: run benchmark
    permissions: 
      pull-requests: write #<-- this one
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - uses: boa-dev/criterion-compare-action@v3
        with:
          branchName: ${{ github.base_ref }}

Homework

The Commenting is not possible from forks. message is printed for any error that createComment might throw. https://github.com/boa-dev/criterion-compare-action/blob/main/main.js#L102

I have not checked if there is a way to differentiate between errors and print helpful ones for each case, but maybe replacing Commenting is not possible from forks. with

`Creating comment failed with error: ${err}
Common causes for that are:
1. GitHub doesn't allow writing comments from forks
2. Your action lacks 'pull-requests: write' permission.`

is good enough.

If ^ that looks ok, I'll make a PR :)