fix(notifications): drop stale credentials when switching ntfy auth type

Author: pauln17

client/src/Pages/Notifications/create/index.tsx

@@ -13,9 +13,9 @@ import { zodResolver } from "@hookform/resolvers/zod";
 import { useGet, usePost, usePatch } from "@/Hooks/UseApi";
 import { useNotificationForm } from "@/Hooks/useNotificationForm";
 import type { NotificationFormData } from "@/Validation/notifications";
-import type { Notification } from "@/Types/Notification";
+import { type Notification, NotificationChannels, AuthTypes } from "@/Types/Notification";
 import { useTranslation } from "react-i18next";
-import { NotificationChannels, AuthTypes } from "@/Types/Notification";
+import { normalizeNtfy } from "@/Utils/NotificationUtils";
 
 const NotificationsCreatePage = () => {
 	const { t } = useTranslation();
@@ -78,9 +78,10 @@ const NotificationsCreatePage = () => {
 	}, [watchedType, t]);
 
 	const onSubmit = async (data: NotificationFormData) => {
+		const payload = normalizeNtfy(data);
 		const result = isEditMode
-			? await patch(`/notifications/${notificationId}`, data)
-			: await post("/notifications", data);
+			? await patch(`/notifications/${notificationId}`, payload)
+			: await post("/notifications", payload);
 		if (result) {
 			navigate("/notifications");
 		}
@@ -352,6 +353,7 @@ const NotificationsCreatePage = () => {
 												helperText={fieldState.error?.message ?? ""}
 											/>
 										)}
+										shouldUnregister={true}
 									/>
 									<Controller
 										name="password"
@@ -370,6 +372,7 @@ const NotificationsCreatePage = () => {
 												helperText={fieldState.error?.message ?? ""}
 											/>
 										)}
+										shouldUnregister={true}
 									/>
 								</>
 							)}
@@ -391,6 +394,7 @@ const NotificationsCreatePage = () => {
 											helperText={fieldState.error?.message ?? ""}
 										/>
 									)}
+									shouldUnregister={true}
 								/>
 							)}
 						</Stack>

client/src/Utils/NotificationUtils.ts

@@ -0,0 +1,17 @@
+import type { NotificationFormData } from "@/Validation/notifications";
+
+export const normalizeNtfy = (data: NotificationFormData): NotificationFormData => {
+	if (data.type !== "ntfy") return data;
+	const authType = data.authType ?? "none";
+	const base = { ...data, authType };
+	switch (authType) {
+		case "none":
+			return { ...base, username: "", password: "", accessToken: "" };
+		case "basic":
+			return { ...base, accessToken: "" };
+		case "bearer":
+			return { ...base, username: "", password: "" };
+		default:
+			return base;
+	}
+};