Fix usage of net.IP as pointer

mraerino · mraerino · commit dec25065656d · 2020-01-05T11:23:24.000+01:00
diff --git a/protocols/ospf/packetv3/common.go b/protocols/ospf/packetv3/common.go
@@ -65,7 +65,7 @@ type deserializableIP struct {
 }
 
 func (ip deserializableIP) ToNetIP() net.IP {
-	return *(net.IPv6(ip.Higher, ip.Lower))
+	return net.IPv6(ip.Higher, ip.Lower)
 }
 
 func serializeIPv6(ip net.IP, buf *bytes.Buffer) {
diff --git a/protocols/ospf/packetv3/lsa_prefix.go b/protocols/ospf/packetv3/lsa_prefix.go
@@ -88,7 +88,7 @@ func DeserializeLSAPrefix(buf *bytes.Buffer) (LSAPrefix, int, error) {
 	if err != nil {
 		return pdu, readBytes, errors.Wrap(err, "unable to decode AddressPrefix")
 	}
-	pdu.Address = *addr
+	pdu.Address = addr
 	readBytes += len(pfxBytes)
 
 	return pdu, readBytes, nil

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ type deserializableIP struct {`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`func (ip deserializableIP) ToNetIP() net.IP {`
`68`		`- return *(net.IPv6(ip.Higher, ip.Lower))`
	`68`	`+ return net.IPv6(ip.Higher, ip.Lower)`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`func serializeIPv6(ip net.IP, buf *bytes.Buffer) {`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ func DeserializeLSAPrefix(buf *bytes.Buffer) (LSAPrefix, int, error) {`
`88`	`88`	`if err != nil {`
`89`	`89`	`return pdu, readBytes, errors.Wrap(err, "unable to decode AddressPrefix")`
`90`	`90`	`}`
`91`		`- pdu.Address = *addr`
	`91`	`+ pdu.Address = addr`
`92`	`92`	`readBytes += len(pfxBytes)`
`93`	`93`
`94`	`94`	`return pdu, readBytes, nil`