Skip to content

Accept --skip option in criterion_main! #903

@sin-ack

Description

@sin-ack

Rust's default test harness accepts the filter to skip tests with the --skip flag. However, the Criterion-generated entrypoint accepts this as a positional argument instead. This makes it hard to use the --skip flag across an entire cargo workspace which contains both benchmarks and regular tests. Please accept the --skip flag as an alternative to the positional argument.

(The default test harness does include a positional argument for filters, but it is instead used to restrict the tests run to those names.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions