Add _full_clean flag to baker.make(), prepare(), and bulk_create()

Fixes model-bakers#523. Adds a _full_clean=False opt-in parameter across all main
creation functions. When True, calls Django's full_clean() on each
instance before saving. For _bulk_create=True, validation runs at
prepare() time and the bulk_create call is wrapped in transaction.atomic()
to ensure atomic rollback if validation fails.

Based on the approach in model-bakers#547 (thanks @berinhard), incorporating feedback
from Rust's review of that PR.

Author: benaduo

CHANGELOG.md

@@ -9,8 +9,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Added
 
+- Add `_full_clean` flag to `baker.make()`, `baker.prepare()`, and `baker.bulk_create()` to run Django model validation (`False` by default) ([#523](https://github.com/model-bakers/model_bakery/issues/523))
+
 ### Changed
 
+- Bulk creation now uses transaction blocks to ensure atomic rollback when `_full_clean=True` validation fails
+
 ### Removed
 
 ## [1.23.4](https://pypi.org/project/model-bakery/1.23.4/)

docs/basic_usage.md

@@ -342,6 +342,30 @@ user_iter = User.objects.all().iterator()
 baker.prepare(Profile, user=user_iter, _quantity=5, _bulk_create=True)
 ```
 
+## Running Model Validation
+
+By default, Model Bakery skips Django's model validation when creating objects. To enable
+it, pass `_full_clean=True`:
+
+```python
+from model_bakery import baker
+from django.core.exceptions import ValidationError
+import pytest
+
+with pytest.raises(ValidationError):
+    baker.make('myapp.Profile', email="not-valid", _full_clean=True)
+```
+
+The flag is also supported by `baker.prepare()`:
+
+```python
+with pytest.raises(ValidationError):
+    baker.prepare('myapp.Profile', email="not-valid", _full_clean=True)
+```
+
+When using `_full_clean=True` with `_bulk_create=True`, all objects are created within a
+transaction and will be rolled back if any validation errors occur.
+
 ## Multi-database support
 
 Model Bakery supports django application with more than one database.

model_bakery/baker.py

@@ -11,6 +11,7 @@
 from django.apps import apps
 from django.conf import settings
 from django.core.exceptions import FieldDoesNotExist
+from django.db import transaction
 from django.db.models import (
     AutoField,
     BooleanField,
@@ -99,6 +100,7 @@ def make(
     _create_files: bool = False,
     _using: str = "",
     _bulk_create: bool = False,
+    _full_clean: bool = False,
     **attrs: Any,
 ) -> M: ...
 
@@ -114,6 +116,7 @@ def make(
     _using: str = "",
     _bulk_create: bool = False,
     _fill_optional: list[str] | bool = False,
+    _full_clean: bool = False,
     **attrs: Any,
 ) -> list[M]: ...
 
@@ -128,6 +131,7 @@ def make(
     _using: str = "",
     _bulk_create: bool = False,
     _fill_optional: list[str] | bool = False,
+    _full_clean: bool = False,
     **attrs: Any,
 ):
     """Create a persisted instance from a given model its associated models.
@@ -144,20 +148,30 @@ def make(
         raise InvalidQuantityException
 
     if _bulk_create:
-        result = bulk_create(baker, _quantity or 1, _save_kwargs=_save_kwargs, **attrs)
+        result = bulk_create(
+            baker,
+            _quantity or 1,
+            _save_kwargs=_save_kwargs,
+            _full_clean=_full_clean,
+            **attrs,
+        )
         return result if _quantity else result[0]
     elif _quantity:
         return [
             baker.make(
                 _save_kwargs=_save_kwargs,
                 _refresh_after_create=_refresh_after_create,
+                _full_clean=_full_clean,
                 **attrs,
             )
             for _ in range(_quantity)
         ]
 
     return baker.make(
-        _save_kwargs=_save_kwargs, _refresh_after_create=_refresh_after_create, **attrs
+        _save_kwargs=_save_kwargs,
+        _refresh_after_create=_refresh_after_create,
+        _full_clean=_full_clean,
+        **attrs,
     )
 
 
@@ -167,6 +181,7 @@ def prepare(
     _quantity: None = None,
     _save_related: bool = False,
     _using: str = "",
+    _full_clean: bool = False,
     **attrs: Any,
 ) -> M: ...
 
@@ -178,6 +193,7 @@ def prepare(
     _save_related: bool = False,
     _using: str = "",
     _fill_optional: list[str] | bool = False,
+    _full_clean: bool = False,
     **attrs: Any,
 ) -> list[M]: ...
 
@@ -188,6 +204,7 @@ def prepare(
     _save_related: bool = False,
     _using: str = "",
     _fill_optional: list[str] | bool = False,
+    _full_clean: bool = False,
     **attrs: Any,
 ):
     """Create but do not persist an instance from a given model.
@@ -202,11 +219,11 @@ def prepare(
 
     if _quantity:
         return [
-            baker.prepare(_save_related=_save_related, **attrs)
+            baker.prepare(_save_related=_save_related, _full_clean=_full_clean, **attrs)
             for i in range(_quantity)
         ]
 
-    return baker.prepare(_save_related=_save_related, **attrs)
+    return baker.prepare(_save_related=_save_related, _full_clean=_full_clean, **attrs)
 
 
 def _recipe(name: str) -> Any:
@@ -403,6 +420,7 @@ def make(
         _refresh_after_create: bool = False,
         _from_manager=None,
         _fill_optional: list[str] | bool = False,
+        _full_clean: bool = False,
         **attrs: Any,
     ):
         """Create and persist an instance of the model associated with Baker instance."""
@@ -413,6 +431,7 @@ def make(
             "_refresh_after_create": _refresh_after_create,
             "_from_manager": _from_manager,
             "_fill_optional": _fill_optional,
+            "_full_clean": _full_clean,
         }
         params.update(attrs)
         return self._make(**params)
@@ -421,13 +440,15 @@ def prepare(
         self,
         _save_related=False,
         _fill_optional: list[str] | bool = False,
+        _full_clean: bool = False,
         **attrs: Any,
     ) -> M:
         """Create, but do not persist, an instance of the associated model."""
         params = {
             "commit": False,
             "commit_related": _save_related,
             "_fill_optional": _fill_optional,
+            "_full_clean": _full_clean,
         }
         params.update(attrs)
         return self._make(**params)
@@ -444,6 +465,7 @@ def _make(  # noqa: C901
         _save_kwargs=None,
         _refresh_after_create=False,
         _from_manager=None,
+        _full_clean=False,
         **attrs: Any,
     ) -> M:
         _save_kwargs = _save_kwargs or {}
@@ -496,6 +518,7 @@ def _make(  # noqa: C901
             _commit=commit,
             _from_manager=_from_manager,
             _save_kwargs=_save_kwargs,
+            _full_clean=_full_clean,
         )
         if commit:
             for related in self.model._meta.related_objects:
@@ -514,7 +537,12 @@ def m2m_value(self, field: ManyToManyField) -> list[Any]:
         return self.generate_value(field)
 
     def instance(
-        self, attrs: dict[str, Any], _commit, _save_kwargs, _from_manager
+        self,
+        attrs: dict[str, Any],
+        _commit,
+        _save_kwargs,
+        _from_manager,
+        _full_clean=False,
     ) -> M:
         one_to_many_keys = {}
         auto_now_keys = {}
@@ -546,6 +574,9 @@ def instance(
             instance, generic_foreign_keys, commit=_commit
         )
 
+        if _full_clean:
+            instance.full_clean()
+
         if _commit:
             instance.save(**_save_kwargs)
             self._handle_one_to_many(instance, one_to_many_keys)
@@ -925,7 +956,9 @@ def _save_related_objs(model, objects, _using=None) -> None:
                 setattr(objects[i], fk.name, fk_obj)
 
 
-def bulk_create(baker: Baker[M], quantity: int, **kwargs) -> list[M]:  # noqa: C901
+def bulk_create(
+    baker: Baker[M], quantity: int, _full_clean: bool = False, **kwargs
+) -> list[M]:  # noqa: C901
     """
     Bulk create entries and all related FKs as well.
 
@@ -936,6 +969,7 @@ def bulk_create(baker: Baker[M], quantity: int, **kwargs) -> list[M]:  # noqa: C
     # quantity number of times, passing in the additional keyword arguments
     entries = [
         baker.prepare(
+            _full_clean=_full_clean,
             **kwargs,
         )
         for _ in range(quantity)
@@ -949,7 +983,11 @@ def bulk_create(baker: Baker[M], quantity: int, **kwargs) -> list[M]:  # noqa: C
     else:
         manager = baker.model._base_manager
 
-    created_entries = manager.bulk_create(entries)
+    if _full_clean:
+        with transaction.atomic():
+            created_entries = manager.bulk_create(entries)
+    else:
+        created_entries = manager.bulk_create(entries)
 
     # set many-to-many relations from kwargs
     for entry in created_entries:

tests/test_baker.py

@@ -5,6 +5,7 @@
 
 from django.apps import apps
 from django.conf import settings
+from django.core.exceptions import ValidationError
 from django.db.models import Manager, ManyToOneRel
 from django.db.models.signals import m2m_changed
 from django.test import TestCase, override_settings
@@ -1535,3 +1536,44 @@ def test_generate_value_crashes_on_many_to_one_rel(self):
         baker_instance = baker.Baker(models.Person)
         with pytest.raises(AttributeError, match="has_default"):
             baker_instance.generate_value(reverse_rel)
+
+
+class TestFullClean:
+    @pytest.mark.django_db
+    def test_make_with_full_clean_valid(self):
+        """_full_clean=True does not interfere with valid objects."""
+        profile = baker.make(models.Profile, _full_clean=True)
+        assert profile.pk is not None
+
+    @pytest.mark.django_db
+    def test_make_with_full_clean_raises_on_invalid(self):
+        """_full_clean=True raises ValidationError for invalid field values."""
+        with pytest.raises(ValidationError):
+            baker.make(models.Profile, email="not-an-email", _full_clean=True)
+
+    @pytest.mark.django_db
+    def test_make_with_full_clean_no_db_entry_on_error(self):
+        """No DB row is created when _full_clean=True raises ValidationError."""
+        with pytest.raises(ValidationError):
+            baker.make(models.Profile, email="not-an-email", _full_clean=True)
+        assert models.Profile.objects.count() == 0
+
+    @pytest.mark.django_db
+    def test_prepare_with_full_clean_raises_on_invalid(self):
+        """_full_clean=True on prepare() validates without hitting the DB."""
+        with pytest.raises(ValidationError):
+            baker.prepare(models.Profile, email="not-an-email", _full_clean=True)
+        assert models.Profile.objects.count() == 0
+
+    @pytest.mark.django_db
+    def test_bulk_create_with_full_clean_rolls_back_on_error(self):
+        """_full_clean=True with _bulk_create=True rolls back all entries on error."""
+        with pytest.raises(ValidationError):
+            baker.make(
+                models.Profile,
+                email="not-an-email",
+                _quantity=5,
+                _bulk_create=True,
+                _full_clean=True,
+            )
+        assert models.Profile.objects.count() == 0