poc: singular pypi repo for late binding external dependencies#3321
Closed
rickeylev wants to merge 2 commits into
Closed
poc: singular pypi repo for late binding external dependencies#3321rickeylev wants to merge 2 commits into
rickeylev wants to merge 2 commits into
Conversation
aignas
reviewed
Oct 5, 2025
aignas
left a comment
aignas
left a comment
Collaborator
There was a problem hiding this comment.
I like this API, this is reasonably easy to understand and is probably easier than doing transitions or anything else that would resolve/override a particular dependency from the hub.
Collaborator
|
This got implemented in #3837 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC for having a single
@pypirepo so that targets can depend on something withouthaving to choose a particular dependency closure (pip.parse hub_name).
The current impl works in a hub-of-hubs fashion, however, I think that indirection
could be removed, since it's known at bzlmod time the spokes that a pip.parse hub points to.