Improve notify_message output to print messages literally

- Use similar printf formating for both text and TAP formats.
  Prevent printf from interpreting `%` as format placeholders and backslash escape sequences, preserving exact failure messages.
- Add shellcheck disable 2329 (same reasoning as 2317).

This ensures notify_message prints messages literally, avoiding misleading or mangled failure output.

Author: Aki Arvio

bash_unit

@@ -17,6 +17,7 @@
 #  https://github.com/bash-unit/bash_unit
 
 # shellcheck disable=2317  # Ignore unreachable - most function are not called.
+# shellcheck disable=2329  # Ignore unreachable - most function are not called.
 # shellcheck disable=2155  # Ignore Declare and assign separately
 # spellchecker: ignore NOCOLOR SHUF
 
@@ -413,8 +414,7 @@ text_format() {
   }
   notify_message() {
     local message="$1"
-    # shellcheck disable=SC2059
-    [[ -z "$message" ]] || printf -- "$message\n"
+    [[ -z "$message" ]] || printf -- "%s\n" "$message"
   }
 
   notify_stdout() {
@@ -468,7 +468,7 @@ tap_format() {
   }
   notify_message() {
     local message="$1"
-    [[ -z "$message" ]] || printf -- "%b\n" "$message" | "$SED" -u -e 's/^/# /'
+    [[ -z "$message" ]] || printf -- "%s\n" "$message" | "$SED" -u -e 's/^/# /'
   }
   notify_stdout() {
     "$SED" 's:^:# out> :' | color "$GREEN"

tests/test_cli.sh

@@ -204,6 +204,30 @@ test_one_test_should_stop_when_assert_fails() {
     "$($BASH_UNIT <(echo 'test_fail() { echo "before failure" >&2 ; assert false ; echo "after failure" >&2 ; }') 2>&1 >/dev/null)"
 }
 
+test_notify_message_handles_percent_signs_as_literal_text() {
+  # Test that printf in notify_message doesn't interpret % as placeholder
+  bash_unit_output=$($BASH_UNIT <(echo 'test_percent() { fail "Expected 100% but got 50%" ; }') 2>&1 | "$GREP" "Expected 100% but got 50%")
+  assert_equals "Expected 100% but got 50%" "$bash_unit_output"
+}
+
+test_notify_message_handles_percent_signs_as_literal_text_tap_format() {
+  # Test that printf in notify_message doesn't interpret % as placeholder
+  bash_unit_output=$($BASH_UNIT -f tap <(echo 'test_percent() { fail "Expected 100% but got 50%" ; }') 2>&1 | "$GREP" "Expected 100% but got 50%")
+  assert_equals "# Expected 100% but got 50%" "$bash_unit_output"
+}
+
+test_notify_message_handles_unicode_escape_sequences_as_literal_text() {
+  # Test that printf in notify_message doesn't interpret escape sequences
+  bash_unit_output=$($BASH_UNIT <(printf '%s\n' 'test_escape() { fail "Symbol: \u2713\nshould be literal" ; }') 2>&1 | "$GREP" 'Symbol:')
+  assert_matches '\\u2713\\nshould' "$bash_unit_output"
+}
+
+test_notify_message_handles_unicode_escape_sequences_as_literal_text_tap_format() {
+  # Test that printf in notify_message doesn't interpret escape sequences
+  bash_unit_output=$($BASH_UNIT -f tap <(printf '%s\n' 'test_escape() { fail "Symbol: \u2713\nshould be literal" ; }') 2>&1 | "$GREP" 'Symbol:')
+  assert_matches '\\u2713\\nshould' "$bash_unit_output"
+}
+
 setup() {
   # fake basic unix commands bash_unit relies on so that
   # we ensure bash_unit keeps working when people fake