[TASK] cleanup code for TYPO3 > 12

Author: achimfritz

Build/phpstan-baseline-13.neon

@@ -72,3 +72,7 @@ parameters:
 			message: "#^Parameter \\#4 \\$drawingConfiguration of class TYPO3\\\\CMS\\\\Backend\\\\View\\\\PageLayoutContext constructor expects TYPO3\\\\CMS\\\\Backend\\\\View\\\\Drawing\\\\DrawingConfiguration, PHPUnit\\\\Framework\\\\MockObject\\\\MockObject&TYPO3\\\\CMS\\\\Core\\\\Http\\\\ServerRequest given\\.$#"
 			count: 1
 			path: ../Tests/Functional/Integrity/IntegrityTest.php
+		-
+			message: "#^Access to an undefined property B13\\\\Container\\\\Backend\\\\ContextMenu\\\\RecordContextMenuItemProvider\\:\\:\\$uriBuilder\\.$#"
+			count: 1
+			path: ../Classes/Backend/ContextMenu/RecordContextMenuItemProvider.php

Classes/Backend/ContextMenu/RecordContextMenuItemProvider.php

@@ -5,14 +5,11 @@
 namespace B13\Container\Backend\ContextMenu;
 
 use TYPO3\CMS\Backend\Routing\UriBuilder;
+use TYPO3\CMS\Core\Information\Typo3Version;
+use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 class RecordContextMenuItemProvider extends \TYPO3\CMS\Backend\ContextMenu\ItemProviders\RecordProvider
 {
-    public function __construct(protected UriBuilder $uriBuilder)
-    {
-        parent::__construct();
-    }
-
     /**
      * Add tx_container_parent to newContentElementWizard Url if it is a tt_content record in a container
      */
@@ -29,7 +26,12 @@ protected function getAdditionalAttributes(string $itemName): array
                 'uid_pid' => -$this->record['uid'],
                 'tx_container_parent' => $this->record['tx_container_parent'],
             ];
-            $url = (string)$this->uriBuilder->buildUriFromRoute('new_content_element_wizard', $urlParameters);
+            if ((new Typo3Version())->getMajorVersion() < 14) {
+                $uriBuilder = GeneralUtility::makeInstance(UriBuilder::class);
+                $url = (string)$uriBuilder->buildUriFromRoute('new_content_element_wizard', $urlParameters);
+            } else {
+                $url = (string)$this->uriBuilder->buildUriFromRoute('new_content_element_wizard', $urlParameters);
+            }
             if (isset($attributes['data-new-wizard-url'])) {
                 $attributes['data-new-wizard-url'] = $url;
             }

Tests/Unit/Tca/RegistryTest.php

@@ -27,7 +27,7 @@ class RegistryTest extends UnitTestCase
     public function getAllAvailableColumnsReturnsEmptyArrayIfNoContainerConfigured(): void
     {
         $eventDispatcher = new NoopEventDispatcher();
-        $iconRegistry = $this->getMockBuilder(IconRegistry::class)->disableOriginalConstructor()->getMock();
+        $iconRegistry = $this->createMock(IconRegistry::class);
         $registry = GeneralUtility::makeInstance(Registry::class, $eventDispatcher, $iconRegistry);
         $columns = $registry->getAllAvailableColumns();
         self::assertSame([], $columns);
@@ -37,7 +37,7 @@ public function getAllAvailableColumnsReturnsEmptyArrayIfNoContainerConfigured()
     public function getPageTsStringReturnsEmptyStringIfNoContainerConfigured(): void
     {
         $eventDispatcher = new NoopEventDispatcher();
-        $iconRegistry = $this->getMockBuilder(IconRegistry::class)->disableOriginalConstructor()->getMock();
+        $iconRegistry = $this->createMock(IconRegistry::class);
         $registry = GeneralUtility::makeInstance(Registry::class, $eventDispatcher, $iconRegistry);
         $res = $registry->getPageTsString();
         self::assertSame('', $res, 'empty string should be returned');