Skip to content

Commit b042739

Browse files
chore: Add deps/deps-dev to commit lint rules (#330)
* refactor(ci): replace JS PR title linter with Python commit linter * Update CONTRIBUTING.md
1 parent 9277fff commit b042739

10 files changed

Lines changed: 368 additions & 196 deletions

File tree

.github/workflows/ci.yml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -12,22 +12,7 @@ on:
1212
branches: [ main ]
1313

1414
jobs:
15-
lint-commits:
16-
# Note: To re-run `lint-commits` after fixing the PR title, close-and-reopen the PR.
17-
runs-on: ubuntu-latest
18-
steps:
19-
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
20-
- name: Use Node.js
21-
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
22-
with:
23-
node-version: 22.x
24-
- name: Check PR title
25-
run: |
26-
node "$GITHUB_WORKSPACE/.github/workflows/lintcommit.js"
27-
2815
build:
29-
needs: lint-commits
30-
3116
runs-on: ubuntu-latest
3217
strategy:
3318
fail-fast: false

.github/workflows/lintcommit.js

Lines changed: 0 additions & 178 deletions
This file was deleted.

.github/workflows/test-parser.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ on:
44
pull_request:
55
paths:
66
- 'ops/parse_sdk_branch.py'
7-
- 'ops/__tests__/**'
7+
- 'ops/tests/**'
88
push:
99
branches: [ main ]
1010
paths:
1111
- 'ops/parse_sdk_branch.py'
12-
- 'ops/__tests__/**'
12+
- 'ops/tests/**'
1313

1414
permissions:
1515
contents: read
@@ -21,4 +21,4 @@ jobs:
2121
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
2222

2323
- name: Run parser tests
24-
run: python ops/__tests__/test_parse_sdk_branch.py
24+
run: python ops/tests/test_parse_sdk_branch.py

CONTRIBUTING.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,14 @@ There is a convenience script for the above that you can run from the root of th
3030
ops/ci-checks.sh
3131
```
3232

33+
This script also validates your commit messages against the [Conventional Commits](https://www.conventionalcommits.org/) format.
34+
Commit all your changes before you run the check. If your working directory is dirty the script will skip commit message validation with a warning.
35+
36+
You can also run the commit message check independently:
37+
```
38+
python ops/lintcommit.py
39+
```
40+
3341
## Coding Standards
3442
Consistency is important for maintainability. Please adhere to the house-style of the repo, unless there's a really
3543
good reason to break pattern.

ops/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+

ops/ci-checks.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,6 @@ echo SUCCESS: typings
1313
# static analysis
1414
hatch fmt
1515
echo SUCCESS: linting/fmt
16+
17+
# commit message validation
18+
python ops/lintcommit.py

0 commit comments

Comments
 (0)