Skip to content

Commit 9e3c3a4

Browse files
committed
fix: revert accidental servicecatalog change from commit bf72ef5
1 parent d3b3af6 commit 9e3c3a4

1 file changed

Lines changed: 2 additions & 8 deletions

File tree

packages/aws-cdk-lib/aws-servicecatalog/lib/private/product-stack-synthesizer.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,8 @@ export class ProductStackSynthesizer extends cdk.StackSynthesizer {
9797
// Multiple Products deploying into the same bucket will use the same 'BucketDeployment' construct.
9898
const deploymentScope = this.assetBucket;
9999
const deploymentCid = 'ProductAssetsDeployment';
100-
let bucketDeployment = deploymentScope.node.tryFindChild(deploymentCid) as BucketDeployment | undefined;
101-
if (!bucketDeployment) {
102-
bucketDeployment = new BucketDeployment(deploymentScope, deploymentCid, {
100+
const bucketDeployment = deploymentScope.node.tryFindChild(deploymentCid) as BucketDeployment | undefined
101+
?? new BucketDeployment(deploymentScope, deploymentCid, {
103102
sources: [source],
104103
destinationBucket: this.assetBucket,
105104
extract: false,
@@ -110,11 +109,6 @@ export class ProductStackSynthesizer extends cdk.StackSynthesizer {
110109
memoryLimit: this.memoryLimit,
111110
outputObjectKeys: false,
112111
});
113-
}
114-
115-
if (Stack.of(deploymentScope) !== this.parentStack) {
116-
bucketDeployment.node.addDependency(this.parentStack);
117-
}
118112
bucketDeployment.addSource(source);
119113

120114
const bucketName = this.physicalNameOfBucket(this.assetBucket);

0 commit comments

Comments
 (0)