Skip to content

Comments

Feature/slinky slurm hyperpod eks#804

Closed
bdaqiq01 wants to merge 1316 commits intoawslabs:mainfrom
bdaqiq01:feature/slinky-slurm-hyperpod-eks
Closed

Feature/slinky slurm hyperpod eks#804
bdaqiq01 wants to merge 1316 commits intoawslabs:mainfrom
bdaqiq01:feature/slinky-slurm-hyperpod-eks

Conversation

@bdaqiq01
Copy link

@bdaqiq01 bdaqiq01 commented Aug 1, 2025

Issue #, if available:

Automate SageMaker HyperPod Slurm Cluster Deployment on EKS

This commit introduces a bash script that automates the deployment of slinky on Amazon a SageMaker HyperPod EKS cluster. Key features include:

  • Cluster configuration generation from CloudFormation stack
  • FSx for Lustre storage class creation
  • AWS Load Balancer Controller installation
  • Slinky prerequisites setup (Prometheus, cert-manager, Slurm Operator)
  • Dynamic Slurm cluster values configuration based on instance types
  • FSx Persistent Volume Claim (PVC) creation and verification
  • Slurm cluster deployment with Helm
  • Network Load Balancer (NLB) configuration for login access

The script includes error handling, progress tracking, and detailed logging to ensure a smooth deployment process. It's designed to work with both G5 and P5 instance types, dynamically allocating resources based on the GPU count and EFA support of the chosen instances.
However the it is only tested on deployment on the g5 instance types. The resource allocation modification based on the instance type is done on the dynamic_pods_allocation function ( this function is not test due to resource capacity unavailability). Currently this function call is made in this set_slurm_values function. If for g5 instance type it does not work please comment out this line and retry. The commented version should also work for instance type p5 where only one pod is deployed in one node.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

shimomut and others added 30 commits October 22, 2024 08:49
Just some spelling and capitalizations.
Signed-off-by: Sean Smith <seaam@amazon.com>
* P5 on AWS Batch

This commit gives a template for running the NCCL tests on AWS Batch using p5 instances and the pre-built container image:

```
public.ecr.aws/hpc-cloud/nccl-tests:latest
```

Signed-off-by: Sean Smith <seaam@amazon.com>

* Removed EFA install

Signed-off-by: Sean Smith <seaam@amazon.com>

* Removed AMI and Placement group

Signed-off-by: Sean Smith <seaam@amazon.com>

---------

Signed-off-by: Sean Smith <seaam@amazon.com>
* Update nccl-tests.Dockerfile

* Remove cudacompat

* Update nccl-tests.Dockerfile

* Update micro-benchmarks/nccl-tests/nccl-tests.Dockerfile

Co-authored-by: mhuguesaws <71357145+mhuguesaws@users.noreply.github.com>

* Update micro-benchmarks/nccl-tests/nccl-tests.Dockerfile

Co-authored-by: mhuguesaws <71357145+mhuguesaws@users.noreply.github.com>

---------

Co-authored-by: mhuguesaws <71357145+mhuguesaws@users.noreply.github.com>
Add standalone CPU DDP example for EKS
Automation Script for onboarding
Signed-off-by: Sean Smith <seaam@amazon.com>
* Deleting LambdaExecutionRole as it is not used

* Cutting dependency to other CF stack
- Enter SubnetID and SecurityGroupID manually.
- Adding FSxLustreFilesystemDNSname in the output.

* Adding MetadataConfiguration so that customers can update the Metadata IOPS configuration after creation

* Updating descriptions of parameters

* Updating README and screenshot, as customers need to enter Subnet ID and Security Group ID
…op (awslabs#489)

* Sync the CF template with what the workshop has been using.
- Removed unnecessary service principal.
- Use AmazonSageMakerClusterInstanceRolePolicy and VPC related inline permissions, to follow the official developer guide doc.
- Adding VPC endpoint for S3

* Associate the S3 endpoint with the public route table, in addition to private one
* Update nccl-tests.Dockerfile

* Update buildspec.yaml

* Update README for EFA version 1.36.0
Signed-off-by: Sean Smith <seaam@amazon.com>
Added onboarding automation script
Signed-off-by: Sean Smith <seaam@amazon.com>
Signed-off-by: Sean Smith <seaam@amazon.com>
Update base nvcr pytorch docker image to 24.09 (which uses NCCL 2.22.3):

https://docs.nvidia.com/deeplearning/frameworks/pytorch-release-notes/rel-24-09.html

Update OFI Nccl and EFA Installer to most up-to-date versions:

https://github.com/aws/aws-ofi-nccl/releases/tag/v1.12.1-aws
Signed-off-by: Sean Smith <seaam@amazon.com>
Signed-off-by: Sean Smith <seaam@amazon.com>
Signed-off-by: Sean Smith <seaam@amazon.com>
* Remove ssh key

* Add security group creation to LDAP server
Signed-off-by: Sean Smith <seaam@amazon.com>
xkoegler-h and others added 26 commits July 9, 2025 11:29
…validation (awslabs#782)

description:

- Ensures the FSx mount point directory exists using Ansible.
- Adds retry logic with delay to handle transient mount issues.
- Verifies mount success by checking mountpoint and file I/O.
- Includes automount trigger and cleanup of test file to validate FS readiness.
Co-authored-by: Prajjwal Sharma <prajjwas@amazon.com>
On 07/15, I started seeing errors while calling the load function:
```
[ERROR] datasets.load: trust_remote_code is not supported anymore.
```

Removing it just seems to work now.
* Update 0.llm-foundry.Dockerfile

* Update 0.llm-foundry.Dockerfile
Co-authored-by: Arun Lokanatha <alokana@amazon.com>
* add GPU accounting

* setup user associations
* initial draft of slinky-slurm

* updated dockerfile and readme

* updated values.yaml

* README.md improvements

* including p5 example artifacts

* added reference to distinct values.yaml files

* made IAM role for OpenZFS CSI driver unique

* updated openzfs instructions for clarity

* updated readme instructions and added lustre storage class file

* updated README and values.yaml files with latest from SchedMD

* updates for Slinky v0.3.0

* Slinky v0.3.0 updates

* code tidy
This commit introduces a Bash script that automates the deployment of Slinky on an Amazon SageMaker HyperPod EKS cluster. The script streamlines the setup process with the following key features:

- Cluster configuration generation based on a CloudFormation stack
- Creation of an FSx for Lustre storage class
- Installation of the AWS Load Balancer Controller
- Setup of Slinky prerequisites (Prometheus, cert-manager, Slurm Operator)
- Dynamic Slurm cluster configuration based on instance types
- Creation and verification of FSx Persistent Volume Claims (PVCs)
- Slurm cluster deployment using Helm
- Configuration of a Network Load Balancer (NLB) for login node access

The script includes error handling, progress tracking, and detailed logging to ensure a smooth deployment experience. It is designed to support both G5 and P5 instance types by dynamically allocating resources based on GPU count and EFA support.

Note:
This script has only been tested on G5 instance types. Dynamic resource allocation is handled by the dynamic_pods_allocation function, which is currently invoked within the set_slurm_values function. This dynamic behavior has not been fully tested.

If you encounter issues with G5 instance deployments, consider commenting out the call to dynamic_pods_allocation in set_slurm_values. The script should still work correctly in this mode to function for P5 instance types, where a single pod is deployed per node.

slinky automation tidy up

added back a deleted file
@KeitaW
Copy link
Collaborator

KeitaW commented Feb 17, 2026

Hi @bdaqiq01 — this PR was automatically closed by GitHub because the repository history was rewritten as part of a cleanup to reduce clone size (details in #959).

Your fork's branch still references the old (pre-rewrite) history, so it can't be reopened directly. To restore your PR, please rebase your fork onto the new main:

# Update your fork's main branch
cd your-fork
git remote add upstream https://github.com/aws-samples/awsome-distributed-training.git  # if not already set
git fetch upstream
git checkout main
git reset --hard upstream/main
git push --force origin main

# Rebase your feature branch
git checkout feature/slinky-slurm-hyperpod-eks
git rebase main
# Resolve any conflicts if needed
git push --force origin feature/slinky-slurm-hyperpod-eks

# Then open a new PR from your fork

Apologies for the inconvenience! If you run into any issues rebasing, feel free to ask for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.