Using product flavors causes incorrect advice

[jstefanowski]

Plugin version
3.6.1

Gradle version
8.13 (also exists on 9.+)

JDK version
21.0.9

Android Gradle Plugin (AGP) version
8.13.2 (the same result on 9.0.1)

reason output for bugs relating to incorrect advice

advice.txt

Describe the bug
Running ./gradlew buildHealth generates an advice that googleImplementation(...) should be replaced with googleDebugImplementation(...), even though the code is used in both debug and release variants. Happens only in project containing product flavors.

• Package structure:
  

• build.gradle.kts
  

• Advice:

Advice for :app
Existing dependencies which should be modified to be as indicated:
  googleDebugImplementation("com.google.android.play:review:2.0.2") (was googleImplementation)

That may be a coincidence but even though the generated advice are showing correct usage:

Source: googleDebug, main
-------------------------
* Imports 1 class: com.google.android.play.core.review.ReviewInfo (implies implementation).

Source: googleDebug, test
-------------------------
(no usages)

Source: googleRelease, main
---------------------------
* Imports 1 class: com.google.android.play.core.review.ReviewInfo (implies implementation).

I usually see that instead of combining googleDebug and googleRelease to googleImplementation it just takes whichever source value is shown first

Additional context
Project:

DagpBug.zip

[autonomousapps]

Thanks for the issue. Is this a new bug? That is, did this work as expected on earlier versions of DAGP?

[jstefanowski]

Hard to say because it is my fist time using DAGP :) However, I have just checked and I'm getting the same problem on versions at least since v3.1.0

Update:
I have checked if it was't caused by Gradle Kotlin Dsl but it also happening in Groovy:

Project