Merge pull request #34 from attogram/fix-phpstan-errors

Fix PHPStan analysis errors

Author: attogram

AGENTS.md

@@ -2,6 +2,10 @@
 
 This document provides instructions and information for AI agents working on the OTE v2 project.
 
+## Testing
+
+Do not run tests unless specifically asked by the user. Tests will be automatically run in the CI/CD pipeline when a pull request is created.
+
 ## Manual Workarounds
 
 If you encounter issues with `php artisan` commands, you may need to create files manually. Here's how:

app/Http/Controllers/Admin/UserController.php

@@ -9,11 +9,6 @@
 
 class UserController extends Controller
 {
-    public function __construct()
-    {
-        $this->middleware(['auth', 'role:' . User::ROLE_ADMIN]);
-    }
-
     public function index()
     {
         $users = User::all();

app/Http/Controllers/SuggestionController.php

@@ -9,11 +9,6 @@
 
 class SuggestionController extends Controller
 {
-    public function __construct()
-    {
-        $this->middleware('auth');
-    }
-
     public function index()
     {
         // Add authorization logic here later (only for admins/workers)

app/Http/Middleware/CheckRole.php

@@ -13,7 +13,7 @@ class CheckRole
      *
      * @param  \Illuminate\Http\Request  $request
      * @param  \Closure  $next
-     * @param  string  $role
+     * @param  string  ...$roles
      * @return mixed
      */
     public function handle(Request $request, Closure $next, ...$roles)

routes/web.php

@@ -48,12 +48,14 @@
 Route::get('/export', [LexiconController::class, 'export'])->name('lexicon.export');
 
 // Suggestion Routes
-Route::get('/suggestions', [\App\Http\Controllers\SuggestionController::class, 'index'])->name('suggestions.index');
-Route::get('/suggestions/create', [\App\Http\Controllers\SuggestionController::class, 'create'])->name('suggestions.create');
-Route::post('/suggestions', [\App\Http\Controllers\SuggestionController::class, 'store'])->name('suggestions.store');
-Route::get('/suggestions/{suggestion}', [\App\Http\Controllers\SuggestionController::class, 'show'])->name('suggestions.show');
-Route::post('/suggestions/{suggestion}/approve', [\App\Http\Controllers\SuggestionController::class, 'approve'])->name('suggestions.approve');
-Route::post('/suggestions/{suggestion}/reject', [\App\Http\Controllers\SuggestionController::class, 'reject'])->name('suggestions.reject');
+Route::middleware('auth')->group(function () {
+    Route::get('/suggestions', [\App\Http\Controllers\SuggestionController::class, 'index'])->name('suggestions.index');
+    Route::get('/suggestions/create', [\App\Http\Controllers\SuggestionController::class, 'create'])->name('suggestions.create');
+    Route::post('/suggestions', [\App\Http\Controllers\SuggestionController::class, 'store'])->name('suggestions.store');
+    Route::get('/suggestions/{suggestion}', [\App\Http\Controllers\SuggestionController::class, 'show'])->name('suggestions.show');
+    Route::post('/suggestions/{suggestion}/approve', [\App\Http\Controllers\SuggestionController::class, 'approve'])->name('suggestions.approve');
+    Route::post('/suggestions/{suggestion}/reject', [\App\Http\Controllers\SuggestionController::class, 'reject'])->name('suggestions.reject');
+});
 
 // Admin Routes
 Route::group(['prefix' => 'admin', 'as' => 'admin.', 'middleware' => ['auth', 'role:admin']], function () {