fix cross device link error on ubuntu

Author: atomicptr

crates/core/src/bridge.rs

@@ -6,7 +6,7 @@ use std::{
 };
 use version_compare::Version;
 
-use crate::github;
+use crate::{github, utils};
 
 #[cfg(target_os = "windows")]
 const EXE_SUFFIX: &'static str = ".exe";
@@ -127,7 +127,7 @@ fn install() -> Result<PathBuf> {
 
     tracing::debug!("New Bridge version found {}", release.tag_name);
 
-    fs::rename(downloaded_file, &path)?;
+    utils::move_file(&downloaded_file, &path)?;
     fs::write(version_path()?, release.tag_name)?;
 
     #[cfg(any(target_os = "linux", target_os = "macos"))]

crates/core/src/defold_annotations.rs

@@ -8,7 +8,7 @@ use anyhow::{Context, Result, bail};
 use version_compare::Version;
 use zip::ZipArchive;
 
-use crate::{github, project};
+use crate::{github, project, utils};
 
 const OWNER: &str = "astrochili";
 const REPOSITORY: &str = "defold-annotations";
@@ -112,7 +112,7 @@ pub fn install() -> Result<()> {
         );
     }
 
-    fs::rename(defold_api_dir, defold_dir)?;
+    utils::move_file(&defold_api_dir, &defold_dir)?;
     fs::write(version_path()?, release.tag_name)?;
 
     github::clear_downloads(OWNER, REPOSITORY)?;

crates/core/src/mobdap.rs

@@ -119,6 +119,8 @@ pub fn update_or_install() -> Result<PathBuf> {
         use std::os::unix::fs::PermissionsExt;
         use tar::Archive;
 
+        use crate::utils;
+
         let tar = GzDecoder::new(file);
         let mut archive = Archive::new(tar);
         archive.unpack(&parent_dir)?;
@@ -131,7 +133,7 @@ pub fn update_or_install() -> Result<PathBuf> {
 
         fs::set_permissions(&mobdap_path, Permissions::from_mode(0o700))?;
 
-        fs::rename(mobdap_path, path()?)?;
+        utils::move_file(&mobdap_path, &path()?)?;
     }
 
     #[cfg(target_os = "windows")]
@@ -147,7 +149,7 @@ pub fn update_or_install() -> Result<PathBuf> {
             bail!("mobdap doesnt exist after unpacking?");
         }
 
-        fs::rename(mobdap_path, path()?)?;
+        utils::move_file(&mobdap_path, &path()?)?;
     }
 
     #[cfg(not(any(target_os = "linux", target_os = "macos", target_os = "windows")))]

crates/core/src/neovide.rs

@@ -120,6 +120,8 @@ pub fn update_or_install() -> Result<PathBuf> {
         use std::os::unix::fs::PermissionsExt;
         use tar::Archive;
 
+        use crate::utils;
+
         let tar = GzDecoder::new(file);
         let mut archive = Archive::new(tar);
         archive.unpack(&parent_dir)?;
@@ -132,7 +134,7 @@ pub fn update_or_install() -> Result<PathBuf> {
 
         fs::set_permissions(&neovide_path, Permissions::from_mode(0o700))?;
 
-        fs::rename(neovide_path, path()?)?;
+        utils::move_file(&neovide_path, &path()?)?;
     }
 
     #[cfg(target_os = "windows")]
@@ -148,7 +150,7 @@ pub fn update_or_install() -> Result<PathBuf> {
             bail!("Neovide doesnt exist after unpacking?");
         }
 
-        fs::rename(neovide_path, path()?)?;
+        utils::move_file(&neovide_path, &path()?)?;
     }
 
     #[cfg(not(any(target_os = "linux", target_os = "windows")))]

crates/core/src/utils.rs

@@ -83,3 +83,19 @@ pub fn delete_empty_dirs_from(root_dir: &Path) -> Result<()> {
     }
     Ok(())
 }
+
+// Apparently fs::rename doesnt work on tmpfs
+pub fn move_file(from: &Path, to: &Path) -> Result<()> {
+    if let Err(err) = fs::rename(from, to) {
+        // EXDEV: Cross-device link
+        if err.raw_os_error() == Some(18) {
+            fs::copy(from, to)?;
+            fs::remove_file(from)?;
+            return Ok(());
+        }
+
+        return Err(err.into());
+    }
+
+    Ok(())
+}