Skip to content

Commit 53c84e4

Browse files
authored
Fix recusion in json object generation (#1210)
1 parent 2938e7f commit 53c84e4

1 file changed

Lines changed: 10 additions & 5 deletions

File tree

src/Result/PutTraceSegmentsResult.php

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,18 +30,23 @@ protected function populateResult(Response $response): void
3030
$this->unprocessedTraceSegments = empty($data['UnprocessedTraceSegments']) ? [] : $this->populateResultUnprocessedTraceSegmentList($data['UnprocessedTraceSegments']);
3131
}
3232

33+
private function populateResultUnprocessedTraceSegment(array $json): UnprocessedTraceSegment
34+
{
35+
return new UnprocessedTraceSegment([
36+
'Id' => isset($json['Id']) ? (string) $json['Id'] : null,
37+
'ErrorCode' => isset($json['ErrorCode']) ? (string) $json['ErrorCode'] : null,
38+
'Message' => isset($json['Message']) ? (string) $json['Message'] : null,
39+
]);
40+
}
41+
3342
/**
3443
* @return UnprocessedTraceSegment[]
3544
*/
3645
private function populateResultUnprocessedTraceSegmentList(array $json): array
3746
{
3847
$items = [];
3948
foreach ($json as $item) {
40-
$items[] = new UnprocessedTraceSegment([
41-
'Id' => isset($item['Id']) ? (string) $item['Id'] : null,
42-
'ErrorCode' => isset($item['ErrorCode']) ? (string) $item['ErrorCode'] : null,
43-
'Message' => isset($item['Message']) ? (string) $item['Message'] : null,
44-
]);
49+
$items[] = $this->populateResultUnprocessedTraceSegment($item);
4550
}
4651

4752
return $items;

0 commit comments

Comments
 (0)