[pyupgrade] Make fix unsafe if it deletes comments (UP033) (#22871)

Author: chirizxc

crates/ruff_linter/resources/test/fixtures/pyupgrade/UP033_0.py

@@ -44,3 +44,11 @@ def lru_cache(maxsize=None):
 @lru_cache(maxsize=None)
 def ok():
     pass
+
+
+
+@functools.lru_cache(
+    maxsize=None,  # text
+)
+def fixme_unsafe():
+    pass

crates/ruff_linter/src/rules/pyupgrade/rules/lru_cache_with_maxsize_none.rs

@@ -1,3 +1,4 @@
+use ruff_diagnostics::Applicability;
 use ruff_python_ast::{self as ast, Arguments, Decorator, Expr, Keyword};
 use ruff_text_size::{Ranged, TextRange};
 
@@ -38,6 +39,9 @@ use crate::{AlwaysFixableViolation, Edit, Fix};
 /// ## Options
 /// - `target-version`
 ///
+/// ## Fix safety
+/// This rule's fix is marked as safe, unless the expression contains comments.
+///
 /// ## References
 /// - [Python documentation: `@functools.cache`](https://docs.python.org/3/library/functools.html#functools.cache)
 #[derive(ViolationMetadata)]
@@ -103,7 +107,21 @@ pub(crate) fn lru_cache_with_maxsize_none(checker: &Checker, decorator_list: &[D
                     )?;
                     let reference_edit =
                         Edit::range_replacement(binding, decorator.expression.range());
-                    Ok(Fix::safe_edits(import_edit, [reference_edit]))
+
+                    let applicability = if checker
+                        .comment_ranges()
+                        .intersects(decorator.expression.range())
+                    {
+                        Applicability::Unsafe
+                    } else {
+                        Applicability::Safe
+                    };
+
+                    Ok(Fix::applicable_edits(
+                        import_edit,
+                        [reference_edit],
+                        applicability,
+                    ))
                 });
             }
         }

crates/ruff_linter/src/rules/pyupgrade/snapshots/ruff_linter__rules__pyupgrade__tests__UP033_0.py.snap

@@ -55,3 +55,26 @@ help: Rewrite with `@functools.cache
 16 | @other_decorator
 17 | def fixme():
 18 |     pass
+
+UP033 [*] Use `@functools.cache` instead of `@functools.lru_cache(maxsize=None)`
+  --> UP033_0.py:50:21
+   |
+50 |   @functools.lru_cache(
+   |  _____________________^
+51 | |     maxsize=None,  # text
+52 | | )
+   | |_^
+53 |   def fixme_unsafe():
+54 |       pass
+   |
+help: Rewrite with `@functools.cache
+47 | 
+48 | 
+49 | 
+   - @functools.lru_cache(
+   -     maxsize=None,  # text
+   - )
+50 + @functools.cache
+51 | def fixme_unsafe():
+52 |     pass
+note: This is an unsafe fix and may change runtime behavior