[ty] Enforce Final attribute assignment rules for annotated and augmented writes

Author: charliermarsh

crates/ty_python_semantic/resources/mdtest/attributes.md

@@ -256,6 +256,43 @@ class C:
 reveal_type(C().w)  # revealed: Unknown | Weird
 ```
 
+#### Ecosystem regression: pip SSL context options
+
+```py
+from unknown_module import unknown  # type: ignore
+
+class SSLContext:
+    options: int = 0
+
+def create_context() -> None:
+    context = SSLContext() if unknown else unknown
+    options = 0
+    options |= unknown
+    context.options |= options
+```
+
+#### Ecosystem regression: spack Mach-O header size sync
+
+```py
+from unknown_module import unknown  # type: ignore
+
+class Header:
+    sizeofcmds: int = 0
+
+class Holder:
+    def __init__(self) -> None:
+        self.header = None
+        self.load()
+
+    def load(self) -> None:
+        self.header = Header() if unknown else unknown
+
+    def synchronize_size(self) -> None:
+        if self.header is None:
+            return
+        self.header.sizeofcmds += unknown
+```
+
 #### Attributes defined in tuple unpackings
 
 ```py

crates/ty_python_semantic/resources/mdtest/type_qualifiers/final.md

@@ -278,6 +278,8 @@ c.INSTANCE_FINAL_A = 2
 c.INSTANCE_FINAL_B = 2
 # error: [invalid-assignment] "Cannot assign to final attribute `INSTANCE_FINAL_C` on type `C`"
 c.INSTANCE_FINAL_C = 2
+# error: [invalid-assignment] "Cannot assign to final attribute `INSTANCE_FINAL_A` on type `C`"
+c.INSTANCE_FINAL_A += 1
 ```
 
 ## Mutability
@@ -624,7 +626,7 @@ from typing import Final
 
 class C:
     def some_method(self):
-        # TODO: This should be an error
+        # error: [invalid-assignment]
         self.x: Final[int] = 1
 ```
 
@@ -889,7 +891,7 @@ python-version = "3.11"
 ```
 
 ```py
-from typing import Final, Self
+from typing import Final, Generic, Self, TypeVar
 
 class ClassA:
     ID4: Final[int]  # OK because initialized in __init__
@@ -907,8 +909,17 @@ class ClassB:
     def __init__(self):  # Without Self annotation
         self.ID5 = 1  # Should also be OK
 
+T = TypeVar("T")
+
+class Box(Generic[T]):
+    value: Final[T]
+
+    def __init__(self: Self, value: T):
+        self.value = value
+
 reveal_type(ClassA().ID4)  # revealed: int
 reveal_type(ClassB().ID5)  # revealed: int
+reveal_type(Box(1).value)  # revealed: int
 ```
 
 ## Reassignment to Final in `__init__`

crates/ty_python_semantic/src/types/function.rs

@@ -1452,16 +1452,13 @@ fn is_instance_truthiness<'db>(
     class: ClassLiteral<'db>,
 ) -> Truthiness {
     let is_instance = |ty: &Type<'_>| {
-        if let Type::NominalInstance(instance) = ty
-            && instance
+        ty.as_nominal_instance().is_some_and(|instance| {
+            instance
                 .class(db)
                 .iter_mro(db)
                 .filter_map(ClassBase::into_class)
-                .any(|c| c.class_literal(db) == class)
-        {
-            return true;
-        }
-        false
+                .any(|mro_class| mro_class.class_literal(db) == class)
+        })
     };
 
     let always_true_if = |test: bool| {