Adjusting height of first row (for keyguards)

[klues]

Moved out from #228 to separate discussions.

My thoughts and points:

• the height of the first line should be configurable in order to adapt it to keyguards
• after the changes from Make global grid more flexible and robust #228 (dynamic grid placeholder) the first row can either be part of the global grid, dynamic grid, or contain elements from global grid and dynamic grid
• therefore it makes no sense to just change the height of the first line of the global grid, but the height of the first line of the combined grid (global + dynamic)
• this is how I've implemented it now with the Height factor for first row which is shown in Edit grid -> More -> Grid settings for both global and dynamic grid
• I think probably it's better that the option is moved to Settings -> Appearance somewhere, because it's a global option for all grids and not related to a specific grid or only global grids

[ms-mialingvo]

I think probably it's better that the option is moved to Settings -> Appearance somewhere, because it's a global option for all grids and not related to a specific grid or only global grids

Yeah, that probably leads to less confusion. (And also yes to the rest.)

[klues]

Now moved the settings to Settings -> Appearance -> Grid (at the bottom) - I think that's most reasonable.
Also changed it, so that it really works all the time, also without having a global grid activated.

Please test at https://gridbeta-github.asterics-foundation.org/klues/732-adjusting-height-first-row/pr

[ms-mialingvo]

Thanks!

Works fine on Chrome and Safari Macbook. In Firefox the last line is slightly cut off in fullscreen or the general-grid-background-color shows. Haven't yet quite figured out when what happens.
What exactly is the height factor number? Thought that it would be the cell line height compared with the average height of the other cell lines but that doesn't seem to be the case.

factor 1.7

factor 4

[klues]

Thanks for testing. For combining the grids and adjusting the height, the numbers of rows and columns are increased internally. Firefox seems to have problems with exact rendering if the internal numbers of rows/columns are big. I've managed to reduce the numbers to some extend, which leads to better rendering in Firefox.

Best is to use the combination of using the new placeholder from #228 and the new setting for adjusting height. If you're not using a placeholder + the new setting for height it's worse, since the old algorithm for combining the grids produces higher internal numbers of rows/columns.
But in your screenshot it looks like you're already using the new placeholder.

Please test again at https://gridbeta-github.asterics-foundation.org/klues/732-adjusting-height-first-row/pr

[ms-mialingvo]

Whatever you did seems to have fixed it, now it's not cutting anything off nor showing extra space :) 👍

[klues]

great! 😆

@arasaac-dga would you also like to test before I merge it?

[Fukurouonthesea]

(tested on Windows 11 / Firefox)
Since this is a relatively complex test grid, here's the global grid I was using for all of these, for clarity:

It still doesn't like an element going over two rows, but that might be a rather rare use case!
And the bottom edge clipping is fixed in at least this browser, I can't test any others.

factor 1.5

factor 0.5 (i didn't delete the first row - it just... was too tiny apparently so it got swallowed by the double-row clipping?)

factor 0.75

Went to test the same numbers without the double speech bar, just to see what it does then - yup, generally it works. Yay!

factor 1.5

factor 0.5

factor 0.75

The background thing belongs to the global grid issue, I think?

Tested what it does when using 1,5 instead of 1.5: doesn't complain, but when going back to the grid, doesn't take the number either - it just keeps the last valid entry. So that's not breaking anything, if someone is unsure which number system to use.
(It does the same thing when entering random shit that's not a number - not that I think anyone would try to break this, but it's how I learned to test programs in school, including reaction to all random definitely not correct actions you can think of)

Actually, when entering 0, it does something different: it goes back to default (1). That was interesting to have a different error-reaction, but it makes a lot of sense.

[arasaac-dga]

great! 😆

@arasaac-dga would you also like to test before I merge it?

Tested with Global Grid activated and deactivated (in case of keywords) and work as expected. In both cases first row show the same height. For us is enough with this configuration with no more complex. Agree with add in the same section the background color.

[juanjofau]

I’ve been testing the beta version, and in my opinion, setting the first-row height configuration at a global level is a mistake. It should be a per-grid configuration, as it was before, since usage and needs can vary considerably between different grids.

For example, there may be grids where it makes sense to reduce the height of the first row because the new cell being developed in parallel is used to display the grid name. In that case, having a smaller first row is reasonable. However, in other grids, such as keyboards, you may prefer not to reduce the first row, since you want to use it like a normal key. Or vice versa: on a keyboard, you may prefer the first row with numbers to be smaller, while on other grids you do not.

Additionally, in my opinion, the first row of the global grid should be treated differently from the first row of the dynamic grid. They should be configurable separately, since the use cases are different. For example, you might want a slightly reduced first row on the global grid for the accumulated sentence, while on the dynamic grid you may or may not want to reduce the first row as well.

In summary, I believe this configuration would be more flexible and adaptable if it were grid-specific and allowed separate configurations for the global grid and the dynamic grid.