Skip to content

Commit ddf83c4

Browse files
committed
Assert createDatabase() success
Pretty much all errors that can happen in createDatabase() end up throwing an exception, however the function still does return a boolean (it bubbles up the value from the underlying $conn->statement() call) which should be checked in at least some way.
1 parent 151e81b commit ddf83c4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Jobs/CreateDatabase.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public function handle(DatabaseManager $databaseManager): bool
4040

4141
try {
4242
$databaseManager->ensureTenantCanBeCreated($this->tenant);
43-
$this->tenant->database()->manager()->createDatabase($this->tenant);
43+
assert($this->tenant->database()->manager()->createDatabase($this->tenant) === true);
4444

4545
event(new DatabaseCreated($this->tenant));
4646
} catch (TenantDatabaseAlreadyExistsException | TenantDatabaseUserAlreadyExistsException $e) {

0 commit comments

Comments
 (0)