Fix flaky test (#399)

* Avoid "precondition failed" upon modifying collection properties

* Avoid "precondition failed" upon modifying collection properties

* Bump version number

* Check for instrumentation

* Increase timeout

Author: apetenchea

.github/workflows/pypi.yaml

@@ -43,10 +43,10 @@ jobs:
         env:
           TWINE_USERNAME: __token__
           TWINE_PASSWORD: ${{ secrets.PYPI_TEST_TOKEN }}
-        run: twine upload --repository testpypi dist/*
+        run: twine upload --verbose --repository testpypi dist/*
 
       - name: Publish to PyPI
         env:
           TWINE_USERNAME: __token__
           TWINE_PASSWORD: ${{ secrets.PYPI_TOKEN }}
-        run: twine upload --repository pypi dist/*
+        run: twine upload --verbose --repository pypi dist/*

arango/version.py

@@ -1 +1 @@
-__version__ = "8.3.2"
+__version__ = "8.3.3"

tests/conftest.py

@@ -46,6 +46,7 @@ class GlobalData:
     secret: str = None
     root_password: str = None
     db_version: version = version.parse("0.0.0")
+    is_instrumented: bool = False
     crash: bool = False
 
 
@@ -138,6 +139,9 @@ def pytest_configure(config):
     )
 
     db_version = sys_db.version()
+    global_data.is_instrumented = (
+        "asan" in db_version or "tsan" in db_version or "coverage" in db_version
+    )
     global_data.db_version = version.parse(db_version.split("-")[0])
 
     # Create a user and non-system database for testing.
@@ -298,6 +302,11 @@ def db_version():
     return global_data.db_version
 
 
+@pytest.fixture(autouse=False)
+def is_instrumented():
+    return global_data.is_instrumented
+
+
 @pytest.fixture(autouse=False)
 def url():
     return global_data.url

tests/test_collection.py

@@ -40,7 +40,7 @@ def test_collection_attributes(db, col, username):
     assert repr(col) == f"<StandardCollection {col.name}>"
 
 
-def test_collection_misc_methods(col, bad_col, cluster, db_version):
+def test_collection_misc_methods(col, bad_col, cluster, db_version, is_instrumented):
     # Test get properties
     properties = col.properties()
     assert properties["name"] == col.name
@@ -65,18 +65,17 @@ def test_collection_misc_methods(col, bad_col, cluster, db_version):
         }
     ]
 
-    with pytest.raises(ValueError):
-        # schema must not be empty
-        properties = col.configure(
-            sync=not prev_sync, schema={}, computed_values=computed_values
-        )
+    sleep_time = 9 if is_instrumented else 3
+    time.sleep(sleep_time)  # Avoid "precondition failed" in slow clusters
 
     properties = col.configure(sync=not prev_sync, computed_values=computed_values)
 
     assert properties["name"] == col.name
     assert properties["system"] is False
     assert properties["sync"] is not prev_sync
     assert properties["computedValues"] == computed_values
+
+    time.sleep(sleep_time)  # Avoid "precondition failed" in slow clusters
     col.configure(computed_values=[])
 
     # Test configure properties with bad collection