Add hash index for getTeamByServers O(1) lookup and yield in request loop

Co-Authored-By: Claude Opus 4.6 <[email protected]>

Author: spraza

fdbserver/DDTeamCollection.actor.cpp

@@ -185,13 +185,10 @@ class DDTeamCollectionImpl {
 
 	// Find the team with the exact storage servers as req.src.
 	static void getTeamByServers(DDTeamCollection* self, GetTeamRequest req) {
-		const std::string servers = TCTeamInfo::serversToString(req.src);
 		Optional<Reference<IDataDistributionTeam>> res;
-		for (const auto& team : self->teams) {
-			if (team->getServerIDsStr() == servers) {
-				res = team;
-				break;
-			}
+		auto it = self->teamsByServerIDs.find(TCTeamInfo::serversToString(req.src));
+		if (it != self->teamsByServerIDs.end()) {
+			res = it->second;
 		}
 		req.reply.send(std::make_pair(res, false));
 	}
@@ -3076,6 +3073,7 @@ class DDTeamCollectionImpl {
 	ACTOR static Future<Void> serverGetTeamRequests(DDTeamCollection* self, TeamCollectionInterface tci) {
 		loop {
 			GetTeamRequest req = waitNext(tci.getTeam.getFuture());
+			wait(yield());
 			if (req.findTeamByServers) {
 				getTeamByServers(self, req);
 			} else {
@@ -4763,6 +4761,7 @@ void DDTeamCollection::addTeam(const std::vector<Reference<TCServerInfo>>& newTe
 
 	// For a good team, we add it to teams and create machine team for it when necessary
 	teams.push_back(teamInfo);
+	teamsByServerIDs[teamInfo->getServerIDsStr()] = teamInfo;
 	for (auto& server : newTeamServers) {
 		server->addTeam(teamInfo);
 	}
@@ -5688,6 +5687,7 @@ void DDTeamCollection::addServer(StorageServerInterface newServer,
 
 bool DDTeamCollection::removeTeam(Reference<TCTeamInfo> team) {
 	TraceEvent("RemovedServerTeam", distributorId).detail("Team", team->getDesc());
+	teamsByServerIDs.erase(team->getServerIDsStr());
 	bool found = false;
 	for (int t = 0; t < teams.size(); t++) {
 		if (teams[t] == team) {

fdbserver/include/fdbserver/DDTeamCollection.h

@@ -682,6 +682,7 @@ class DDTeamCollection : public ReferenceCounted<DDTeamCollection> {
 	std::vector<Reference<TCMachineTeamInfo>> machineTeams; // all machine teams
 
 	std::vector<Reference<TCTeamInfo>> teams;
+	std::unordered_map<std::string, Reference<TCTeamInfo>> teamsByServerIDs;
 
 	std::vector<DDTeamCollection*> teamCollections;
 	AsyncTrigger printDetailedTeamsInfo;