Add verified workspace auto-approval

Author: appatalks

README-2.md

@@ -90,7 +90,8 @@ files and are normalized before Eva uses them.
 - LCARS and Eva themes (7 Eva variants)
 - Standalone Electron AppImage with bundled bridge
 - Durable coding workspaces with automatic Eva-ready Git project provisioning,
-  isolated worktrees, workspace-confined ACP agents, and durable run records
+  isolated worktrees, workspace-confined ACP agents, durable run records, and
+  optional per-run auto approval for remote or otherwise sensitive actions
 - Real Electron PTY terminal with xterm rendering, bounded replay, resize/search,
   lower-half Workspace Monitor docking, and process-session cancellation
 - Main-window Workspace Monitor, unified generated/workspace Assets library,
@@ -1334,16 +1335,30 @@ Workspace agents reuse the observable subagent registry, so the same task is
 visible in Agent Operations with `coding_run_id`, `checkout_id`, and
 `capability_policy`. Unlike generic subagents, the worker creates its
 `ACPClient` with the assigned worktree and uses prompt permission mode
-`workspace_write`.
+`workspace_write`, or `workspace_auto` when **Auto approve actions** is enabled
+for the run. The composer remembers that choice locally for later runs.
 
 ACP `session/request_permission` requests are automatically allowed once only
-for `read`, `search`, `fetch`, and `think` tool kinds when the active workspace
-prompt offers an `allow_once` option. Execute, edit, delete, and unknown tool
-kinds require an explicit permission decision because ACP does not provide a
-path contract that can prove worktree confinement. Ordinary chats and generic
-subagents retain interactive permission handling; passive recall continues to
-reject tools. The automatic mode never accepts persistent `allow_always`
-authority.
+for routine workspace reads, local edits, and trusted local build/test commands.
+With `workspace_auto`, Eva also selects one-time approval for remote tools such
+as GitHub CLI issue comments. Auto approval still rejects edits outside the
+assigned worktree and commands referencing protected credential/config paths.
+For an explicit GitHub Issues objective, Eva may use the authenticated `gh`
+CLI. A named issue receives a comment; when no target is named and no matching
+open issue exists, Eva creates a new issue containing the requested report. The
+run completes only after its final `Submitted:` issue/comment URL resolves
+through GitHub. Explicit close and reopen objectives additionally verify the
+issue endpoint reports the requested `closed` or `open` state before completion.
+Failed workspace agents are not automatically replayed on application startup,
+which prevents remote side effects from being duplicated after an ambiguous
+failure. Their retained run exposes an explicit **Retry** action instead.
+Ordinary chats and generic subagents retain interactive permission handling;
+passive recall continues to reject tools. Neither workspace mode accepts
+persistent `allow_always` authority.
+
+Settings > Auth launches GitHub CLI device authorization, opens GitHub's device
+page, copies the one-time code when possible, and keeps the code visible with a
+Copy code button until authorization completes.
 
 Live ACP chunks update the task and periodically persist a bounded report.
 Plan/tool events update activity. Completion persists the final report and
@@ -1792,7 +1807,7 @@ not a supported agent-state protocol.
 - Bridge binds to `127.0.0.1` by default (localhost only)
 - ACP tool permissions are never globally bypassed. Standalone Eva requires an authenticated in-chat decision; hosted/file clients fail closed.
 - Workspace routes require a second random capability held only by Electron main; the ordinary renderer-visible bridge token is insufficient.
-- Workspace agent `workspace_write` prompts auto-select `allow_once` only for read/search/fetch/think; mutating and unknown tools remain interactive. Normal prompts remain interactive and passive recall remains deny-by-policy.
+- Workspace agent `workspace_write` prompts auto-select `allow_once` for confined reads, edits, and trusted local commands. User-enabled `workspace_auto` also approves other one-time actions, while outside-worktree edits and protected-path commands are rejected by policy. Normal prompts remain interactive and passive recall remains deny-by-policy.
 - Renderer workspace DTOs contain opaque IDs and relative paths only. Known project/worktree paths are redacted from agent reports.
 - Managed worktree paths are revalidated under `EVA_CONFIG_DIR/worktrees` before status, Assets, terminal registration, and cleanup. Runtime-root, intermediate, leaf, and post-registration symlink swaps are rejected.
 - PTY roots are allowlisted; the renderer cannot provide a cwd/environment. PTY shutdown retains Unix session identity and escalates descendants to SIGKILL before root revocation.

README.md

@@ -4,7 +4,7 @@
 
 [Website](https://appatalks.github.io/eva-agent/) | [Documentation](README-2.md) | [Issues](https://github.com/appatalks/eva-agent/issues) | License: MIT
 
-A voice-first AI assistant for conversation, memory, automation, and local or cloud-backed work. Eva can use voice, camera, browser, desktop, MCP tools, skills, and coding workspaces while keeping control and configuration on your machine.
+A voice-first AI assistant for conversation, memory, automation, and local or cloud-backed work. Eva can use voice, camera, browser, desktop, MCP tools, skills, and coding workspaces with optional auto approval while keeping control and configuration on your machine.
 
 ## In Use
 

core/js/workspaces.js

@@ -37,6 +37,15 @@ var EvaWorkspaces = (function() {
     return !!(value && value.workspaceTerminalV1 && value.workspaceListProjects && value.workspaceCreateRun);
   }
 
+  function autoApprovePreference(value) {
+    try {
+      if (typeof value === 'boolean') localStorage.setItem('workspaceAutoApprove', value ? 'true' : 'false');
+      return localStorage.getItem('workspaceAutoApprove') === 'true';
+    } catch (_) {
+      return false;
+    }
+  }
+
   function panel() {
     return document.getElementById('workspacePanel');
   }
@@ -219,6 +228,22 @@ var EvaWorkspaces = (function() {
     }
   }
 
+  async function retryWorkspaceRun(run) {
+    if (!run || !api() || typeof api().workspaceDispatchRun !== 'function' || state.loading) return;
+    setBusy(true);
+    status('Retrying workspace agent...', 'loading');
+    try {
+      var updated = await api().workspaceDispatchRun(run.id);
+      state.selectedProjectId = updated.projectId;
+      state.selectedRunId = updated.id;
+      await refresh();
+      status('Workspace agent retry started.', 'success');
+    } catch (error) {
+      status(error.message || 'Workspace agent retry failed.', 'error');
+      setBusy(false);
+    }
+  }
+
   function appendWorkspacePermissions(detail, run) {
     var permissions = state.pendingPermissions.filter(function(permission) { return permission.workspaceRunId === run.id; });
     if (!permissions.length) return;
@@ -298,6 +323,11 @@ var EvaWorkspaces = (function() {
       actions.appendChild(actionButton('Chat', 'Open this run\'s primary chat', function() { loadSession(run.primarySessionId); }));
     }
     var agentActive = run.agent && ['starting', 'running', 'steering'].indexOf(run.agent.status) !== -1;
+    if (run.status === 'active' && run.agent && run.agent.status === 'error') {
+      actions.appendChild(actionButton('Retry', 'Retry this failed workspace run', function() {
+        retryWorkspaceRun(run);
+      }));
+    }
     if ((run.status === 'active' || run.status === 'completed') && !agentActive) {
       actions.appendChild(actionButton('Archive', 'Keep this run and hide it from active work', function() { applyRunAction(run, 'archive'); }));
       actions.appendChild(actionButton('Discard', 'Review removal of this managed worktree', function() {
@@ -638,7 +668,7 @@ var EvaWorkspaces = (function() {
   }
 
   function appendWorkbenchRunComposer(detail, project) {
-    var draft = state.runDrafts[project.id] || (state.runDrafts[project.id] = { objective: '', baseRef: 'HEAD' });
+    var draft = state.runDrafts[project.id] || (state.runDrafts[project.id] = { objective: '', baseRef: 'HEAD', autoApprove: autoApprovePreference() });
     var section = document.createElement('section');
     section.className = 'workspace-workbench-section';
     var heading = document.createElement('h2');
@@ -660,17 +690,29 @@ var EvaWorkspaces = (function() {
     baseRef.maxLength = 256;
     baseRef.value = draft.baseRef || 'HEAD';
     baseRef.autocomplete = 'off';
+    var autoApprove = document.createElement('label');
+    autoApprove.className = 'workspace-auto-approve';
+    var autoApproveInput = document.createElement('input');
+    autoApproveInput.type = 'checkbox';
+    autoApproveInput.checked = draft.autoApprove === true;
+    var autoApproveText = document.createElement('span');
+    autoApproveText.textContent = 'Auto approve actions';
+    autoApprove.append(autoApproveInput, autoApproveText);
     objective.addEventListener('input', function() { draft.objective = objective.value; });
     baseRef.addEventListener('input', function() { draft.baseRef = baseRef.value; });
+    autoApproveInput.addEventListener('change', function() {
+      draft.autoApprove = autoApproveInput.checked;
+      autoApprovePreference(autoApproveInput.checked);
+    });
     var submit = document.createElement('button');
     submit.type = 'submit';
     submit.textContent = 'Start isolated run';
     submit.disabled = state.loading || !supported();
-    form.append(objectiveLabel, objective, baseLabel, baseRef, submit);
+    form.append(objectiveLabel, objective, baseLabel, baseRef, autoApprove, submit);
     form.addEventListener('submit', async function(event) {
       event.preventDefault();
       submit.disabled = true;
-      var created = await createWorkspaceRun(project.id, objective.value, baseRef.value);
+      var created = await createWorkspaceRun(project.id, objective.value, baseRef.value, { autoApprove: autoApproveInput.checked });
       if (created) {
         draft.objective = '';
         draft.baseRef = 'HEAD';
@@ -897,6 +939,13 @@ var EvaWorkspaces = (function() {
         openWorkspaceTerminal(selected.checkout.id, (selected.project ? selected.project.name + ' | ' : '') + (selected.checkout.branch || 'worktree'));
       });
       actions.appendChild(terminalButton);
+      if (selected.status === 'active' && selected.agent && selected.agent.status === 'error') {
+        var retryButton = document.createElement('button');
+        retryButton.type = 'button';
+        retryButton.textContent = 'Retry run';
+        retryButton.addEventListener('click', function() { retryWorkspaceRun(selected); });
+        actions.appendChild(retryButton);
+      }
       if (selected.primarySessionId && typeof loadSession === 'function') {
         var chatButton = document.createElement('button');
         chatButton.type = 'button';
@@ -1257,6 +1306,13 @@ var EvaWorkspaces = (function() {
 
   function showGitHubAuthState(authState) {
     var stateValue = authState && authState.state || 'failed';
+    var device = document.getElementById('authGitHubDevice');
+    var deviceCode = document.getElementById('authGitHubDeviceCode');
+    var authStatus = document.getElementById('authGitHubCliStatus');
+    var pending = stateValue === 'pending' && authState && authState.code;
+    if (device) device.hidden = !pending;
+    if (deviceCode) deviceCode.textContent = pending ? authState.code : '';
+    if (authStatus) authStatus.textContent = authState && authState.message || '';
     if (stateValue === 'starting') {
       status(authState.message || 'Starting GitHub device authorization...', 'loading');
       return;
@@ -1479,12 +1535,16 @@ var EvaWorkspaces = (function() {
     setBusy(true);
     status('Creating isolated worktree...', 'loading');
     try {
+      var autoApprove = options && typeof options.autoApprove === 'boolean'
+        ? options.autoApprove
+        : autoApprovePreference();
       var primarySessionId = typeof _activeSessionId === 'function' ? _activeSessionId() : '';
       var run = await api().workspaceCreateRun({
         projectId: project.id,
         objective: objective,
         primarySessionId: primarySessionId,
-        baseRef: String(baseRefValue || '').trim() || 'HEAD'
+        baseRef: String(baseRefValue || '').trim() || 'HEAD',
+        autoApprove: autoApprove
       });
       state.selectedProjectId = run.projectId;
       state.selectedRunId = run.id;
@@ -1533,10 +1593,12 @@ var EvaWorkspaces = (function() {
     var projectSelect = document.getElementById('workspaceProjectSelect');
     var objective = document.getElementById('workspaceObjective');
     var baseRef = document.getElementById('workspaceBaseRef');
+    var autoApprove = document.getElementById('workspaceAutoApprove');
     var created = await createWorkspaceRun(
       projectSelect ? projectSelect.value : '',
       objective ? objective.value : '',
-      baseRef ? baseRef.value : 'HEAD'
+      baseRef ? baseRef.value : 'HEAD',
+      { autoApprove: !!(autoApprove && autoApprove.checked) }
     );
     if (created && objective) objective.value = '';
   }
@@ -1605,6 +1667,7 @@ var EvaWorkspaces = (function() {
     var workbenchGitHubImport = document.getElementById('workspaceImportGitHubBtn');
     var workbenchGitHubList = document.getElementById('workspaceListGitHubBtn');
     var workbenchGitHubAuth = document.getElementById('authGitHubCliBtn');
+    var githubCopyCode = document.getElementById('authGitHubCopyCodeBtn');
     var workbenchGitHubCollapse = document.getElementById('workspaceCollapseGitHubBtn');
     var monitorRefresh = document.getElementById('workspaceMonitorRefreshBtn');
     var monitorClose = document.getElementById('workspaceMonitorCloseBtn');
@@ -1618,6 +1681,15 @@ var EvaWorkspaces = (function() {
     if (workbenchAddProject) workbenchAddProject.addEventListener('click', addProject);
     if (workbenchGitHubImport) workbenchGitHubImport.addEventListener('click', importGitHubProject);
     if (workbenchGitHubAuth) workbenchGitHubAuth.addEventListener('click', authorizeGitHub);
+    if (githubCopyCode) githubCopyCode.addEventListener('click', function() {
+      var code = document.getElementById('authGitHubDeviceCode');
+      if (!code || !code.textContent || !navigator.clipboard) return;
+      navigator.clipboard.writeText(code.textContent).then(function() {
+        status('GitHub device code copied.', 'success');
+      }).catch(function() {
+        status('Could not copy the GitHub device code.', 'error');
+      });
+    });
     if (workbenchGitHubCollapse) workbenchGitHubCollapse.addEventListener('click', collapseGitHubRepositories);
     if (workbenchGitHubList) workbenchGitHubList.addEventListener('click', function() {
       listGitHubRepositories().catch(function(error) { status(error.message || 'GitHub repository listing failed.', 'error'); });
@@ -1634,6 +1706,11 @@ var EvaWorkspaces = (function() {
     });
     if (!supported()) renderUnavailable();
     else {
+      var autoApprove = document.getElementById('workspaceAutoApprove');
+      if (autoApprove) {
+        autoApprove.checked = autoApprovePreference();
+        autoApprove.addEventListener('change', function() { autoApprovePreference(autoApprove.checked); });
+      }
       monitor();
       state.monitorTimer = setInterval(monitor, 10000);
     }

core/style.css

@@ -471,6 +471,9 @@ body.eva-standalone #settingsMenu {
       margin: 0 0 12px;
     }
     .auth-field { margin-bottom: 12px; }
+    .auth-device-code { display: flex; align-items: center; gap: 8px; margin: 8px 0; padding: 8px; border: 1px solid #ccc; border-radius: 4px; }
+    .auth-device-code[hidden] { display: none; }
+    .auth-device-code strong { flex: 1; font: 700 16px monospace; letter-spacing: 0; }
     .auth-input-wrap {
       display: flex;
       gap: 6px;
@@ -1029,10 +1032,13 @@ body.memory-view-open .memory-inspector-panel .session-panel-header { padding: 1
 .workspace-workbench-section p { margin: 0; color: #84aab0; font-size: 11px; line-height: 1.45; }
 .workspace-workbench-run-form { display: grid; gap: 8px; }
 .workspace-workbench-run-form label { color: #7fa3a9; font: 700 9px monospace; letter-spacing: 0.08em; }
+.workspace-auto-approve { display: flex; align-items: center; gap: 7px; color: inherit; cursor: pointer; }
+.workspace-auto-approve input { width: 15px; height: 15px; margin: 0; accent-color: #78dce8; }
+.workspace-auto-approve span { font-size: 11px; letter-spacing: 0; }
 .workspace-workbench-run-form textarea,
-.workspace-workbench-run-form input { box-sizing: border-box; width: 100%; margin: 0; border: 1px solid rgba(120,220,232,0.22); border-radius: 3px; background: rgba(2,11,14,0.72); color: #e7fbff; font: 12px/1.4 monospace; }
+.workspace-workbench-run-form input[type="text"] { box-sizing: border-box; width: 100%; margin: 0; border: 1px solid rgba(120,220,232,0.22); border-radius: 3px; background: rgba(2,11,14,0.72); color: #e7fbff; font: 12px/1.4 monospace; }
 .workspace-workbench-run-form textarea { min-height: 88px; padding: 8px; resize: vertical; }
-.workspace-workbench-run-form input { height: 32px; padding: 0 8px; }
+.workspace-workbench-run-form input[type="text"] { height: 32px; padding: 0 8px; }
 .workspace-workbench-run-form button { min-height: 34px; border: 1px solid rgba(120,220,232,0.32); border-radius: 3px; background: rgba(120,220,232,0.08); color: #dcfbff; font: 700 10px monospace; cursor: pointer; }
 .workspace-workbench-run-form button:hover:not(:disabled) { border-color: #78dce8; background: rgba(120,220,232,0.15); }
 .workspace-mcp-list { display: grid; gap: 2px; }

index.html

@@ -334,6 +334,10 @@ <h4 class="settings-subhead">My skills</h4>
         <select id="workspaceProjectSelect" aria-label="Project for new coding run"></select>
         <label for="workspaceObjective">Coding run</label>
         <textarea id="workspaceObjective" rows="3" maxlength="4000" placeholder="Describe the change Eva should make"></textarea>
+        <label class="workspace-auto-approve" for="workspaceAutoApprove">
+          <input id="workspaceAutoApprove" type="checkbox">
+          <span>Auto approve actions</span>
+        </label>
         <div class="workspace-run-options">
           <label for="workspaceBaseRef">Base</label>
           <input id="workspaceBaseRef" type="text" value="HEAD" maxlength="256" autocomplete="off">
@@ -949,7 +953,12 @@ <h2 id="settingsPageTitle">General</h2>
           </div>
           <p class="auth-note">For private repository imports, grant the selected repository Contents: Read access. Fine-grained tokens must include that repository; classic tokens need the <code>repo</code> scope.</p>
           <button id="authGitHubCliBtn" type="button" class="auth-toggle" title="Authorize GitHub CLI using a device code">Authorize GitHub CLI</button>
-          <p class="auth-note">Eva opens the GitHub device page and copies the one-time code. Complete sign-in in GitHub; the credential stays in GitHub CLI storage.</p>
+          <div id="authGitHubDevice" class="auth-device-code" hidden aria-live="polite">
+            <span>Device code</span>
+            <strong id="authGitHubDeviceCode"></strong>
+            <button id="authGitHubCopyCodeBtn" type="button" class="auth-toggle">Copy code</button>
+          </div>
+          <p id="authGitHubCliStatus" class="auth-note">Eva opens the GitHub device page and shows the one-time code here. Complete sign-in in GitHub; the credential stays in GitHub CLI storage.</p>
         </div>
 
         <div class="auth-field">