From 0b1ad9d8ebf077ae9bfdbc9d207be62eada9b819 Mon Sep 17 00:00:00 2001 From: Yicong Huang Date: Sat, 13 Jun 2026 15:21:58 -0700 Subject: [PATCH 1/2] chore(amber): move test-only deps to dev-requirements.txt MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit pytest, pytest-reraise, pytest-timeout, and iniconfig were pinned in amber/requirements.txt despite being test-only. Per the header comment in amber/dev-requirements.txt, test deps belong there so they stay out of the LICENSE-binary snapshot and the production CU Docker images (which install requirements.txt + operator-requirements.txt only). Move pytest, pytest-reraise, pytest-timeout to dev-requirements.txt. Drop iniconfig entirely — it is pytest's transitive and gets pulled in automatically. Remove matching entries from amber/system-requirements-lock.txt (its header says it tracks requirements + operator-requirements) and from amber/LICENSE-binary-python. Closes #5691 --- amber/LICENSE-binary-python | 4 ---- amber/dev-requirements.txt | 6 ++++++ amber/requirements.txt | 4 ---- amber/system-requirements-lock.txt | 4 ---- 4 files changed, 6 insertions(+), 12 deletions(-) diff --git a/amber/LICENSE-binary-python b/amber/LICENSE-binary-python index 3b0f155997c..862a19b6825 100644 --- a/amber/LICENSE-binary-python +++ b/amber/LICENSE-binary-python @@ -262,7 +262,6 @@ Python packages: - h2==4.3.0 - hpack==4.1.0 - hyperframe==6.1.0 - - iniconfig==1.1.1 - jmespath==1.1.0 - loguru==0.7.0 - markdown-it-py==4.2.0 @@ -275,9 +274,6 @@ Python packages: - pydantic-core==2.46.4 - pyparsing==3.3.2 - pyroaring==1.1.0 - - pytest==7.4.0 - - pytest-reraise==2.1.2 - - pytest-timeout==2.2.0 - pytz==2026.2 - pyyaml==6.0.3 - readerwriterlock==1.0.9 diff --git a/amber/dev-requirements.txt b/amber/dev-requirements.txt index 7ae68cf4a2c..57b1cfaa3d5 100644 --- a/amber/dev-requirements.txt +++ b/amber/dev-requirements.txt @@ -20,6 +20,12 @@ # pip-licenses output and never need to be tracked in LICENSE-binary # / NOTICE-binary. Not installed by packaging. +# pytest test runner and plugins. Pytest's INI/TOML config parser +# (iniconfig) is pulled in as a transitive — no need to pin it here. +pytest==7.4.0 +pytest-reraise==2.1.2 +pytest-timeout==2.2.0 + # Coverage instrumentation for pytest; emits coverage.xml consumed by # Codecov's Phase 1 upload. pytest-cov==5.0.0 diff --git a/amber/requirements.txt b/amber/requirements.txt index 726310934dd..6588ecd0ffb 100644 --- a/amber/requirements.txt +++ b/amber/requirements.txt @@ -19,18 +19,14 @@ setuptools==80.10.2 numpy==2.1.0 pandas==2.2.3 ruff==0.14.7 -iniconfig==1.1.1 loguru==0.7.0 pyarrow==21.0.0 -pytest==7.4.0 python-dateutil==2.8.2 -pytest-timeout==2.2.0 protobuf==7.34.1 betterproto==2.0.0b7 pampy==0.3.0 overrides==7.4.0 typing_extensions==4.14.1 -pytest-reraise==2.1.2 Deprecated==1.2.14 fs==2.4.16 praw==7.6.1 diff --git a/amber/system-requirements-lock.txt b/amber/system-requirements-lock.txt index 29f67d38222..5fb86a58977 100644 --- a/amber/system-requirements-lock.txt +++ b/amber/system-requirements-lock.txt @@ -46,7 +46,6 @@ h2==4.3.0 hpack==4.1.0 hyperframe==6.1.0 idna==3.15 -iniconfig==1.1.1 jmespath==1.1.0 loguru==0.7.0 markdown-it-py==4.2.0 @@ -73,9 +72,6 @@ pyiceberg==0.11.1 pympler==1.1 pyparsing==3.3.2 pyroaring==1.1.0 -pytest==7.4.0 -pytest-reraise==2.1.2 -pytest-timeout==2.2.0 python-dateutil==2.8.2 pytz==2026.2 readerwriterlock==1.0.9 From 67451db0fe15fbf80b25be5692133e1c361e1a3b Mon Sep 17 00:00:00 2001 From: Yicong Huang Date: Sat, 13 Jun 2026 16:29:52 -0700 Subject: [PATCH 2/2] chore(amber): also drop pluggy from LICENSE / lock pluggy is a pytest transitive (not directly imported anywhere in the repo); once pytest moves to dev-requirements.txt it is no longer installed during the LICENSE-binary snapshot, so check_binary_deps.py flags it as stale. Drop the matching lines. --- amber/LICENSE-binary-python | 1 - amber/system-requirements-lock.txt | 1 - 2 files changed, 2 deletions(-) diff --git a/amber/LICENSE-binary-python b/amber/LICENSE-binary-python index 862a19b6825..1a3202bf113 100644 --- a/amber/LICENSE-binary-python +++ b/amber/LICENSE-binary-python @@ -269,7 +269,6 @@ Python packages: - mmh3==5.2.1 - pampy==0.3.0 - plotly==5.24.1 - - pluggy==1.6.0 - pydantic==2.13.4 - pydantic-core==2.46.4 - pyparsing==3.3.2 diff --git a/amber/system-requirements-lock.txt b/amber/system-requirements-lock.txt index 5fb86a58977..3447f3e5894 100644 --- a/amber/system-requirements-lock.txt +++ b/amber/system-requirements-lock.txt @@ -58,7 +58,6 @@ packaging==26.2 pampy==0.3.0 pandas==2.2.3 pg8000==1.31.5 -pluggy==1.6.0 praw==7.6.1 prawcore==2.4.0 propcache==0.5.2