Skip to content

Commit 5b3c274

Browse files
committed
[SPARK-57719][SQL][TEST] Move IdentifierClauseParserSuite to the catalyst parser package
### What changes were proposed in this pull request? This PR moves `IdentifierClauseParserSuite` to `org.apache.spark.sql.catalyst.parser` (`sql/catalyst`) so its directory and package match. ### Why are the changes needed? This file was introduced at Spark 4.1.1 by the following. - #53407 https://github.com/apache/spark/blob/688064e691a63a44075dee769eb07ceed19068f6/sql/core/src/test/scala/org/apache/spark/sql/execution/command/IdentifierClauseParserSuite.scala#L18-L18 The suite is a Catalyst-level parser test (extends `AnalysisTest`, uses `CatalystSqlParser`) with no `sql/core` dependency, but it was placed under `execution/command` while declaring the top-level `org.apache.spark.sql` package. It's weird. Moving it next to the sibling parser suites fixes the directory/package mismatch. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.8 Closes #56813 from dongjoon-hyun/SPARK-57719. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 1409070) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
1 parent 3a8786b commit 5b3c274

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

sql/core/src/test/scala/org/apache/spark/sql/execution/command/IdentifierClauseParserSuite.scala renamed to sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/IdentifierClauseParserSuite.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,11 @@
1515
* limitations under the License.
1616
*/
1717

18-
package org.apache.spark.sql
18+
package org.apache.spark.sql.catalyst.parser
1919

2020
import org.apache.spark.sql.catalyst.analysis.{AnalysisTest, ExpressionWithUnresolvedIdentifier, UnresolvedAttribute, UnresolvedExtractValue, UnresolvedFunction, UnresolvedInlineTable, UnresolvedStar}
2121
import org.apache.spark.sql.catalyst.expressions.{Alias, Cast, LambdaFunction, Literal, UnresolvedNamedLambdaVariable}
2222
import org.apache.spark.sql.catalyst.parser.CatalystSqlParser.parsePlan
23-
import org.apache.spark.sql.catalyst.parser.ParseException
2423
import org.apache.spark.sql.catalyst.plans.logical.{InsertIntoStatement, OneRowRelation, Pivot, Project, SubqueryAlias, Unpivot}
2524
import org.apache.spark.sql.catalyst.util.EvaluateUnresolvedInlineTable
2625
import org.apache.spark.sql.types.{IntegerType, StringType, StructField, StructType}

0 commit comments

Comments
 (0)