[MSHARED-1364] AbstractMavenReportRenderer should not depend on Doxia impl classes

[jira-importer]

Konrad Windszus opened MSHARED-1364 and commented

The classes in package o.a.m.doxia.sink.impl should by definition not be considered stable API (and therefore only consumed from Doxia classes internally).
However https://github.com/apache/maven-reporting-impl/blob/72181306bb0e12eed50c4ba4aec98dd76499df39/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java#L47 depends on some internal constants.
This is dangerous, as those constants were removed in the context of DOXIA-685. Although constants are inlined during compile time, the evaluation of those constants vanished as well, so using them has no longer any effect. Reporting Impl should only rely on stable Doxia API to achieve a better decoupling.

---

Affects: maven-reporting-impl-4.0.0-M13

[jira-importer]

Michael Osipov commented

What do you recommend to do in such a case? Where should this class (SinkEventAttributeSet) be?

[jira-importer]

Konrad Windszus commented

I would recommend copy it to https://github.com/apache/maven-doxia/tree/e01880801ca1283b86205e2f7064b9b4dbc84d54/doxia-sink-api/src/main/java/org/apache/maven/doxia/sink (and at the same time deprecate the other one).

[jira-importer]

Michael Osipov commented

I see and then extend from to retain binary compat? If so, please create a ticket and do so.

[slachiewicz]

@kwin do You think it's worth to work on it?