Skip to content

Commit 5dda5a3

Browse files
authored
test: Rename TypeTest to VisitTypeTest to avoid naming conflict (#546)
1 parent fa2a3d5 commit 5dda5a3

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/iceberg/test/visit_type_test.cc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -210,23 +210,23 @@ const static std::array<TypeTestCase, 4> kNestedTypes = {{
210210

211211
} // namespace
212212

213-
class TypeTest : public ::testing::TestWithParam<TypeTestCase> {};
213+
class VisitTypeTest : public ::testing::TestWithParam<TypeTestCase> {};
214214

215-
INSTANTIATE_TEST_SUITE_P(Primitive, TypeTest, ::testing::ValuesIn(kPrimitiveTypes),
215+
INSTANTIATE_TEST_SUITE_P(Primitive, VisitTypeTest, ::testing::ValuesIn(kPrimitiveTypes),
216216
TypeTestCaseToString);
217217

218-
INSTANTIATE_TEST_SUITE_P(Nested, TypeTest, ::testing::ValuesIn(kNestedTypes),
218+
INSTANTIATE_TEST_SUITE_P(Nested, VisitTypeTest, ::testing::ValuesIn(kNestedTypes),
219219
TypeTestCaseToString);
220220

221-
TEST_P(TypeTest, VisitTypePrintToString) {
221+
TEST_P(VisitTypeTest, VisitTypePrintToString) {
222222
TypeNameVisitor visitor;
223223
std::ostringstream oss;
224224
const auto& test_case = GetParam();
225225
ASSERT_THAT(VisitTypeInline(*test_case.type, &visitor, oss), IsOk());
226226
ASSERT_EQ(oss.str(), test_case.repr);
227227
}
228228

229-
TEST_P(TypeTest, VisitTypeReturnNestedTypeId) {
229+
TEST_P(VisitTypeTest, VisitTypeReturnNestedTypeId) {
230230
auto visitor = [&](auto&& type) -> Result<TypeId> {
231231
using Type = std::remove_cvref_t<decltype(type)>;
232232
// Check if the type is a nested type

0 commit comments

Comments
 (0)