Skip to content

Commit 71c7d69

Browse files
committed
test: add testkit infrastructure and refactor unit tests with JUnit 5 parameterized patterns
Implements Phase 1-2 of the test modernization proposal from issue #717: - Add testkit/ package with AbstractExcelTest, ExcelFormat enum, CollectingReadListener, and ExcelAssertions for shared test infrastructure - Migrate converter and other legacy test packages to parameterized JUnit 5 tests - Remove listener classes with embedded assertions (SRP violation) - Consolidate scattered model classes into organized packages (core/, format/, readwrite/, sheet/, style/) - Apply parameterized test pattern to cover XLSX/XLS/CSV in single methods - Update DateUtils to support test infrastructure Closes #717
1 parent 3986b8b commit 71c7d69

163 files changed

Lines changed: 5901 additions & 6960 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

fesod-sheet/src/main/java/org/apache/fesod/sheet/util/DateUtils.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -549,9 +549,9 @@ public static boolean isADateFormatUncached(Short formatIndex, String formatStri
549549
*/
550550
public static boolean isInternalDateFormat(short format) {
551551
switch (format) {
552-
// Internal Date Formats as described on page 427 in
553-
// Microsoft Excel Dev's Kit...
554-
// 14-22
552+
// Internal Date Formats as described on page 427 in
553+
// Microsoft Excel Dev's Kit...
554+
// 14-22
555555
case 0x0e:
556556
case 0x0f:
557557
case 0x10:
@@ -561,7 +561,7 @@ public static boolean isInternalDateFormat(short format) {
561561
case 0x14:
562562
case 0x15:
563563
case 0x16:
564-
// 45-47
564+
// 45-47
565565
case 0x2d:
566566
case 0x2e:
567567
case 0x2f:

fesod-sheet/src/test/java/org/apache/fesod/sheet/FesodSheetTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ void testRead_noArgs_shouldReturnBuilder() {
189189
}
190190

191191
@Test
192-
void testRead_withFile_shouldConfigureFile() throws Exception {
192+
void testRead_withFile_shouldConfigureFile() {
193193
ExcelReaderBuilder builder = FesodSheet.read(tempFile);
194194
assertNotNull(builder);
195195
ReadWorkbook workbook = writeWorkbook(builder);

fesod-sheet/src/test/java/org/apache/fesod/sheet/annotation/AnnotationDataListener.java

Lines changed: 0 additions & 63 deletions
This file was deleted.

fesod-sheet/src/test/java/org/apache/fesod/sheet/annotation/AnnotationDataTest.java

Lines changed: 0 additions & 157 deletions
This file was deleted.

fesod-sheet/src/test/java/org/apache/fesod/sheet/annotation/AnnotationIndexAndNameDataListener.java

Lines changed: 0 additions & 59 deletions
This file was deleted.

0 commit comments

Comments
 (0)