add more tests

Author: Pearl1594

engine/storage/snapshot/src/test/java/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategyTest.java

@@ -22,6 +22,7 @@
 import java.util.List;
 import java.util.UUID;
 
+import org.apache.cloudstack.engine.subsystem.api.storage.StrategyPriority;
 import org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDao;
 import org.apache.cloudstack.storage.datastore.db.StoragePoolVO;
 import org.apache.cloudstack.storage.to.VolumeObjectTO;
@@ -39,13 +40,19 @@
 import com.cloud.storage.Volume;
 import com.cloud.storage.VolumeVO;
 import com.cloud.storage.dao.VolumeDao;
+import com.cloud.vm.UserVmVO;
+import com.cloud.vm.VirtualMachine.State;
+import com.cloud.vm.dao.UserVmDao;
+import com.cloud.vm.snapshot.VMSnapshot;
 
 @RunWith(MockitoJUnitRunner.class)
 public class DefaultVMSnapshotStrategyTest {
     @Mock
     VolumeDao volumeDao;
     @Mock
     PrimaryDataStoreDao primaryDataStoreDao;
+    @Mock
+    UserVmDao userVmDao;
 
     @Spy
     @InjectMocks
@@ -85,7 +92,7 @@ public void testUpdateVolumePath() {
         Mockito.when(vol2.getChainInfo()).thenReturn(newVolChain);
         Mockito.when(vol2.getSize()).thenReturn(vmSnapshotChainSize);
         Mockito.when(vol2.getId()).thenReturn(volumeId);
-        VolumeVO volumeVO = new VolumeVO("name", 0l, 0l, 0l, 0l, 0l, "folder", "path", Storage.ProvisioningType.THIN, 0l, Volume.Type.ROOT);
+        VolumeVO volumeVO = new VolumeVO("name", 0L, 0L, 0L, 0L, 0L, "folder", "path", Storage.ProvisioningType.THIN, 0L, Volume.Type.ROOT);
         volumeVO.setPoolId(oldPoolId);
         volumeVO.setChainInfo(oldVolChain);
         volumeVO.setPath(oldVolPath);
@@ -103,4 +110,110 @@ public void testUpdateVolumePath() {
         Assert.assertEquals(vmSnapshotChainSize, persistedVolume.getVmSnapshotChainSize());
         Assert.assertEquals(newVolChain, persistedVolume.getChainInfo());
     }
+
+    @Test
+    public void testCanHandleRunningVMOnClvmStorageCantHandle() {
+        Long vmId = 1L;
+        VMSnapshot vmSnapshot = Mockito.mock(VMSnapshot.class);
+        Mockito.when(vmSnapshot.getVmId()).thenReturn(vmId);
+
+        UserVmVO vm = Mockito.mock(UserVmVO.class);
+        Mockito.when(vm.getId()).thenReturn(vmId);
+        Mockito.when(vm.getState()).thenReturn(State.Running);
+        Mockito.when(userVmDao.findById(vmId)).thenReturn(vm);
+
+        VolumeVO volumeOnClvm = createVolume(vmId, 1L);
+        List<VolumeVO> volumes = List.of(volumeOnClvm);
+        Mockito.when(volumeDao.findByInstance(vmId)).thenReturn(volumes);
+
+        StoragePoolVO clvmPool = createStoragePool("clvm-pool", Storage.StoragePoolType.CLVM);
+        Mockito.when(primaryDataStoreDao.findById(1L)).thenReturn(clvmPool);
+
+        StrategyPriority result = defaultVMSnapshotStrategy.canHandle(vmSnapshot);
+
+        Assert.assertEquals("Should return CANT_HANDLE for running VM on CLVM storage",
+                StrategyPriority.CANT_HANDLE, result);
+    }
+
+    @Test
+    public void testCanHandleStoppedVMOnClvmStorageCanHandle() {
+        Long vmId = 1L;
+        VMSnapshot vmSnapshot = Mockito.mock(VMSnapshot.class);
+        Mockito.when(vmSnapshot.getVmId()).thenReturn(vmId);
+
+        UserVmVO vm = Mockito.mock(UserVmVO.class);
+        Mockito.when(vm.getId()).thenReturn(vmId);
+        Mockito.when(vm.getState()).thenReturn(State.Stopped);
+        Mockito.when(userVmDao.findById(vmId)).thenReturn(vm);
+
+        StrategyPriority result = defaultVMSnapshotStrategy.canHandle(vmSnapshot);
+        Assert.assertEquals("Should return DEFAULT for stopped VM on CLVM storage",
+                StrategyPriority.DEFAULT, result);
+    }
+
+    @Test
+    public void testCanHandleRunningVMOnNfsStorageCanHandle() {
+        Long vmId = 1L;
+        VMSnapshot vmSnapshot = Mockito.mock(VMSnapshot.class);
+        Mockito.when(vmSnapshot.getVmId()).thenReturn(vmId);
+
+        UserVmVO vm = Mockito.mock(UserVmVO.class);
+        Mockito.when(vm.getId()).thenReturn(vmId);
+        Mockito.when(vm.getState()).thenReturn(State.Running);
+        Mockito.when(userVmDao.findById(vmId)).thenReturn(vm);
+
+        VolumeVO volumeOnNfs = createVolume(vmId, 1L);
+        List<VolumeVO> volumes = List.of(volumeOnNfs);
+        Mockito.when(volumeDao.findByInstance(vmId)).thenReturn(volumes);
+
+        StoragePoolVO nfsPool = createStoragePool("nfs-pool", Storage.StoragePoolType.NetworkFilesystem);
+        Mockito.when(primaryDataStoreDao.findById(1L)).thenReturn(nfsPool);
+
+        StrategyPriority result = defaultVMSnapshotStrategy.canHandle(vmSnapshot);
+
+        Assert.assertEquals("Should return DEFAULT for running VM on NFS storage",
+                StrategyPriority.DEFAULT, result);
+    }
+
+    @Test
+    public void testCanHandleRunningVMWithMixedStorageClvmAndNfsCantHandle() {
+        // Arrange - VM has volumes on both CLVM and NFS
+        Long vmId = 1L;
+        VMSnapshot vmSnapshot = Mockito.mock(VMSnapshot.class);
+        Mockito.when(vmSnapshot.getVmId()).thenReturn(vmId);
+
+        UserVmVO vm = Mockito.mock(UserVmVO.class);
+        Mockito.when(vm.getId()).thenReturn(vmId);
+        Mockito.when(vm.getState()).thenReturn(State.Running);
+        Mockito.when(userVmDao.findById(vmId)).thenReturn(vm);
+
+        VolumeVO volumeOnClvm = createVolume(vmId, 1L);
+        VolumeVO volumeOnNfs = createVolume(vmId, 2L);
+        List<VolumeVO> volumes = List.of(volumeOnClvm, volumeOnNfs);
+        Mockito.when(volumeDao.findByInstance(vmId)).thenReturn(volumes);
+
+        StoragePoolVO clvmPool = createStoragePool("clvm-pool", Storage.StoragePoolType.CLVM);
+        StoragePoolVO nfsPool = createStoragePool("nfs-pool", Storage.StoragePoolType.NetworkFilesystem);
+        Mockito.when(primaryDataStoreDao.findById(1L)).thenReturn(clvmPool);
+
+        StrategyPriority result = defaultVMSnapshotStrategy.canHandle(vmSnapshot);
+
+        Assert.assertEquals("Should return CANT_HANDLE if any volume is on CLVM storage for running VM",
+                StrategyPriority.CANT_HANDLE, result);
+    }
+
+    private VolumeVO createVolume(Long vmId, Long poolId) {
+        VolumeVO volume = new VolumeVO("volume", 0L, 0L, 0L, 0L, 0L,
+                "folder", "path", Storage.ProvisioningType.THIN, 0L, Volume.Type.ROOT);
+        volume.setInstanceId(vmId);
+        volume.setPoolId(poolId);
+        return volume;
+    }
+
+    private StoragePoolVO createStoragePool(String name, Storage.StoragePoolType poolType) {
+        StoragePoolVO pool = Mockito.mock(StoragePoolVO.class);
+        Mockito.when(pool.getName()).thenReturn(name);
+        Mockito.when(pool.getPoolType()).thenReturn(poolType);
+        return pool;
+    }
 }