Skip to content

Commit ee56069

Browse files
chore(csharp): Update DuckDB (#3811)
Update to a newer version of DuckDB and the tests that broke with the previous version.
1 parent f43a6ef commit ee56069

File tree

3 files changed

+3
-17
lines changed

3 files changed

+3
-17
lines changed

csharp/Directory.Packages.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
<PackageVersion Include="Azure.Identity" Version="1.17.1" />
3232
<PackageVersion Include="BenchmarkDotNet" Version="0.15.8" />
3333
<PackageVersion Include="coverlet.collector" Version="6.0.4" />
34-
<PackageVersion Include="DuckDB.NET.Bindings.Full" Version="1.4.1" />
34+
<PackageVersion Include="DuckDB.NET.Bindings.Full" Version="1.4.3" />
3535
<PackageVersion Include="K4os.Compression.LZ4" Version="1.3.8" />
3636
<PackageVersion Include="K4os.Compression.LZ4.Streams" Version="1.3.8" />
3737
<PackageVersion Include="Google.Cloud.BigQuery.Storage.V1" Version="3.17.0" />

csharp/test/Apache.Arrow.Adbc.Tests/Client/DuckDbClientTests.cs

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -129,14 +129,7 @@ public void BindParameters()
129129
command.CommandText = "select ?, ?";
130130
command.Prepare();
131131
Assert.Equal(2, command.Parameters.Count);
132-
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
133-
{
134-
Assert.Equal(string.Empty, command.Parameters[0].ParameterName);
135-
}
136-
else
137-
{
138-
Assert.Equal("0", command.Parameters[0].ParameterName);
139-
}
132+
Assert.Equal("0", command.Parameters[0].ParameterName);
140133
Assert.Equal(DbType.Object, command.Parameters[0].DbType);
141134
Assert.Equal("1", command.Parameters[1].ParameterName);
142135
Assert.Equal(DbType.Object, command.Parameters[1].DbType);

csharp/test/Apache.Arrow.Adbc.Tests/ImportedDuckDbTests.cs

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -221,14 +221,7 @@ public void PrepareAndBind()
221221
statement.Prepare();
222222
var schema = statement.GetParameterSchema();
223223
Assert.Equal(2, schema.FieldsList.Count);
224-
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
225-
{
226-
Assert.Equal(string.Empty, schema.FieldsList[0].Name);
227-
}
228-
else
229-
{
230-
Assert.Equal("0", schema.FieldsList[0].Name);
231-
}
224+
Assert.Equal("0", schema.FieldsList[0].Name);
232225
Assert.Equal(ArrowTypeId.Null, schema.FieldsList[0].DataType.TypeId);
233226
Assert.Equal("1", schema.FieldsList[1].Name);
234227
Assert.Equal(ArrowTypeId.Null, schema.FieldsList[1].DataType.TypeId);

0 commit comments

Comments
 (0)