Skip to content

Commit 22a9bee

Browse files
RanabirChakrabortyhcherukuri
authored andcommitted
AMW-621 amq collection spelling and grammar checking for PRs
1 parent f403685 commit 22a9bee

10 files changed

Lines changed: 134 additions & 10 deletions

File tree

.cspell/custom-dictionary.txt

Lines changed: 67 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
1+
# JWS / Tomcat / Ansible domain-specific words
2+
# Only terms NOT covered by built-in dictionaries
3+
4+
# Product names and projects
5+
Wildfly
6+
Infinispan
7+
jolokia
8+
9+
# Java / Tomcat terms
10+
aspectj
11+
beanutils
12+
cglib
13+
dbcp
14+
easymock
15+
hamcrest
16+
jaspic
17+
jaxb
18+
jaxen
19+
jaxrpc
20+
jaxws
21+
jdom
22+
jndi
23+
JNDI
24+
JSSE
25+
jstl
26+
juli
27+
mbeans
28+
objenesis
29+
oraclepki
30+
tagsoup
31+
tomcatjss
32+
xerces
33+
xpowered
34+
osgi
35+
keepgenerated
36+
changeit
37+
Jsps
38+
mappedfile
39+
40+
# Ansible terms
41+
fqcn
42+
FQCN
43+
unarchived
44+
45+
# WildFly / JBoss terms
46+
modcluster
47+
48+
# Linux / System terms
49+
firewalld
50+
procps
51+
restorecon
52+
semanage
53+
semodule
54+
seport
55+
56+
# Molecule testing
57+
preinstalledjdk
58+
59+
# CI / DevOps
60+
sangonzal
61+
rootperm
62+
63+
# RST / Sphinx directives
64+
toctree
65+
66+
# Miscellaneous
67+
subcomponents

.github/workflows/ci.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,18 @@ on:
99
- cron: '0 6 * * *'
1010

1111
jobs:
12+
spellcheck:
13+
runs-on: ubuntu-latest
14+
steps:
15+
- name: Check out code
16+
uses: actions/checkout@v7
17+
18+
- name: Run cspell
19+
uses: streetsidesoftware/cspell-action@v9
20+
with:
21+
incremental_files_only: false
22+
use_cspell_files: true
23+
1224
ci:
1325
uses: ansible-middleware/github-actions/.github/workflows/ci.yml@rootperm
1426
secrets: inherit

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ The plug-ins and modules that are within a collection might be tested with speci
2626
- Installs JBoss Web Server from product archive files or RPM packages
2727
- Assigns ownership of the JBoss Web Server directories to the appropriate user account and group
2828
- Deploys the `server.xml`, `web.xml`, and `context.xml` files
29-
- The [jws_validation](https://github.com/ansible-middleware/jws/blob/main/roles/jws_validation/README.md) role contains a set of utility playbooks and tasks to validate that the server was properly installed on the target and is functionnal.
29+
- The [jws_validation](https://github.com/ansible-middleware/jws/blob/main/roles/jws_validation/README.md) role contains a set of utility playbooks and tasks to validate that the server was properly installed on the target and is functional.
3030
<!--end role_content -->
3131

3232
## Collection setup

cspell.json

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
{
2+
"$schema": "https://raw.githubusercontent.com/streetsidesoftware/cspell/main/cspell.schema.json",
3+
"version": "0.2",
4+
"language": "en",
5+
"ignorePaths": [
6+
"changelogs/**",
7+
"CHANGELOG.rst",
8+
"roles/jws/templates/web.xml.j2"
9+
],
10+
"files": [
11+
"**/*.md",
12+
"**/*.rst",
13+
"roles/*/meta/argument_specs.yml",
14+
"roles/*/meta/main.yml",
15+
"roles/*/tasks/**/*.yml",
16+
"roles/*/defaults/*.yml",
17+
"roles/*/handlers/*.yml",
18+
"roles/*/templates/*.j2",
19+
"molecule/**/*.yml",
20+
"molecule/**/*.j2",
21+
"playbooks/**/*.yml",
22+
"meta/runtime.yml",
23+
"meta/execution-environment.yml",
24+
".github/workflows/*.yml",
25+
".github/ISSUE_TEMPLATE/*.md",
26+
"galaxy.yml"
27+
],
28+
"dictionaries": ["custom-jws", "java", "bash", "shellscript", "fullstack", "softwareTerms", "software-tools", "cpp-compound-words", "python", "docker", "k8s", "html", "css", "git", "networking-terms", "node", "npm"],
29+
"dictionaryDefinitions": [
30+
{
31+
"name": "custom-jws",
32+
"path": ".cspell/custom-dictionary.txt",
33+
"addWords": true
34+
}
35+
],
36+
"ignoreRegExpList": [
37+
"/\\{\\{.*?\\}\\}/g",
38+
"/`[^`]+`/g",
39+
"/(https?:\\/\\/[^\\s)]+)/g",
40+
"/\\|`?[a-z_]+`?\\|/g",
41+
"/\\[.*?\\]\\(.*?\\)/g",
42+
"/^\\s*authors?:.*$/gm",
43+
"/^\\s*-\\s+.*<[^>]+>.*$/gm"
44+
]
45+
}

molecule/override_server_xml/verify.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
ansible.builtin.set_fact:
2929
matches: "{{ slurped_server_xml['content'] | b64decode | regex_findall(jvm_route) }}"
3030

31-
- name: "Checks that occurence of {{ jvm_route }} was found."
31+
- name: "Checks that occurrence of {{ jvm_route }} was found."
3232
ansible.builtin.assert:
3333
that:
3434
- matches is defined

roles/jws/meta/argument_specs.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ argument_specs:
2626
type: "bool"
2727
jws_install_download_archive_require_privilege_escalation:
2828
default: True
29-
description: "Whether or not to become root to donwload the archive"
29+
description: "Whether or not to become root to download the archive"
3030
type: "bool"
3131
jws_install_unarchive_require_privilege_escalation:
3232
default: True
@@ -353,7 +353,7 @@ argument_specs:
353353
jws_systemd_script_shebang:
354354
# line 54 of jws/defaults/main.yml
355355
default: "#!/bin/{{ jws_systemd_script_interpreter }}"
356-
description: "Customize sysVinit script sheband"
356+
description: "Customize sysVinit script shebang"
357357
type: "str"
358358
jws_service_name:
359359
# line 55 of jws/defaults/main.yml
@@ -424,7 +424,7 @@ argument_specs:
424424
options:
425425
jws_skip_delete_zipfile:
426426
required: False
427-
description: "Whether to skip deleteion of zipfile when uninstalling"
427+
description: "Whether to skip deletion of zipfile when uninstalling"
428428
type: "bool"
429429
jws_home:
430430
default: "{{ jws_install_dir }}/{{ jws_zipfile_rootdir }}"
@@ -446,7 +446,7 @@ argument_specs:
446446
options:
447447
jws_enable:
448448
default: True
449-
description: "Wheter or not to use JWS instead of uptream"
449+
description: "Whether or not to use JWS instead of upstream"
450450
type: "bool"
451451
jws_version:
452452
default: "6.1.0"

roles/jws/tasks/apply_cp/apply_cp.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
- name: "Check prerequirements."
2+
- name: "Check prerequisites."
33
ansible.builtin.include_tasks: prereqs.yml
44

55
- name: "Download patches from RHN if requested."

roles/jws/tasks/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@
150150
- webapps
151151
- bin
152152

153-
- name: "Ensure {{ jws_home }}/ files have the recommended priviliges, owner and group"
153+
- name: "Ensure {{ jws_home }}/ files have the recommended privileges, owner and group"
154154
become: "{{ jws_install_requires_become | default(true) }}"
155155
ansible.builtin.file:
156156
path: "{{ jws_home }}/{{ item }}"

roles/jws_validation/tasks/apply_cp.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
- name: "Check that required paramters have been provided."
2+
- name: "Check that required parameters have been provided."
33
ansible.builtin.assert:
44
that:
55
- checksum_file_name is defined

roles/jws_validation/tasks/service_status.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@
1919
ansible.builtin.debug:
2020
var: catalina_out
2121

22-
- name: Fail after priting the logfile
22+
- name: Fail after printing the logfile
2323
ansible.builtin.fail:
2424
msg: Service is not running or not enable

0 commit comments

Comments
 (0)