Skip to content

Commit e396cc1

Browse files
committed
addressed reviews
1 parent df0f7ce commit e396cc1

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

nodescraper/plugins/inband/dmesg/dmesg_analyzer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
from typing import Optional
2929

3030
from nodescraper.base.regexanalyzer import ErrorRegex, RegexAnalyzer
31-
from nodescraper.connection.inband import BaseFileArtifact
31+
from nodescraper.connection.inband import TextFileArtifact
3232
from nodescraper.enums import EventCategory, EventPriority
3333
from nodescraper.models import Event, TaskResult
3434

@@ -386,7 +386,7 @@ def analyze_data(
386386
args.analysis_range_end,
387387
)
388388
self.result.artifacts.append(
389-
BaseFileArtifact(filename="filtered_dmesg.log", contents=dmesg_content)
389+
TextFileArtifact(filename="filtered_dmesg.log", contents=dmesg_content)
390390
)
391391
else:
392392
dmesg_content = data.dmesg_content

nodescraper/taskresulthooks/filesystemloghook.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def process_result(self, task_result: TaskResult, data: Optional[DataModel] = No
6060

6161
artifact_map = {}
6262
for artifact in task_result.artifacts:
63-
if isinstance(artifact, BaseFileArtifact):
63+
if issubclass(artifact, BaseFileArtifact):
6464
log_name = get_unique_filename(log_path, artifact.filename)
6565
artifact.log_model(log_path)
6666

0 commit comments

Comments
 (0)