Skip to content

Commit 5e19a02

Browse files
author
jaspals
committed
test fix
1 parent 43d4584 commit 5e19a02

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

test/unit/plugin/test_network_collector.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -336,11 +336,8 @@ def run_sut_cmd_side_effect(cmd, **kwargs):
336336
assert len(data.routes) == 3
337337
assert len(data.rules) == 3
338338
assert len(data.neighbors) == 2
339-
assert "2 interfaces" in result.message
340-
assert "3 routes" in result.message
341-
assert "3 rules" in result.message
342-
assert "2 neighbors" in result.message
343-
assert "ethtool" in result.message
339+
# Since nicctl commands fail in this test, we expect the failure message
340+
assert "Network data collection failed" in result.message
344341

345342

346343
def test_collect_data_addr_failure(collector, conn_mock):
@@ -1093,8 +1090,12 @@ def run_sut_cmd_side_effect(cmd, **kwargs):
10931090
rdma_statistics_entries,
10941091
version_host_software,
10951092
version_firmware_entries,
1093+
uncollected_commands,
10961094
) = collector._collect_pensando_nic_info()
10971095

1096+
# All commands succeeded, so uncollected_commands should be empty
1097+
assert len(uncollected_commands) == 0
1098+
10981099
assert len(cards) == 2
10991100
assert cards[0].id == "1111111-4c32-3533-3330-12345000000"
11001101
assert cards[0].pcie_bdf == "0000:06:00.0"

0 commit comments

Comments
 (0)